Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(e2e): dismiss the sync modal by the label the UI renders

Alfredo Lopeze3e31c941aff
diff --git a/tests/e2e/playwright/package-lock.json b/tests/e2e/playwright/package-lock.json
index a6a185489..2b15e957e 100644
--- a/tests/e2e/playwright/package-lock.json
+++ b/tests/e2e/playwright/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-playwright-tests",
- "version": "0.1.56",
+ "version": "0.1.57",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-playwright-tests",
- "version": "0.1.56",
+ "version": "0.1.57",
"devDependencies": {
"@playwright/test": "^1.50.0",
"@types/node": "^22.0.0",
diff --git a/tests/e2e/playwright/package.json b/tests/e2e/playwright/package.json
index 849d186e8..aaca5495d 100644
--- a/tests/e2e/playwright/package.json
+++ b/tests/e2e/playwright/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-playwright-tests",
- "version": "0.1.56",
+ "version": "0.1.57",
"private": true,
"description": "Playwright E2E tests for Control UI and Desktop App",
"scripts": {
diff --git a/tests/e2e/playwright/pages/codex-subscription.ts b/tests/e2e/playwright/pages/codex-subscription.ts
index 7a624c346..dacf5d202 100644
--- a/tests/e2e/playwright/pages/codex-subscription.ts
+++ b/tests/e2e/playwright/pages/codex-subscription.ts
@@ -153,8 +153,17 @@ export class SecretsLlmSubscriptionsPage {
await expect(dialog.getByRole('group', { name: 'Enabled models' })).toHaveCount(0)
}
+ // The dismiss button carries two labels: CodexSubscriptionHub renders
+ // `creating && editing && setupNew ? 'Finish later' : 'Cancel'`, and every
+ // caller here arrives straight from createGrant, which is that state. Its
+ // handler only runs `setCreating(false); closeEdit()`, so dismissing leaves
+ // the created grant and its enabled models untouched, exactly as the older
+ // `Cancel` label did before the setup form landed.
async closeConnectModal() {
- await this.page.getByRole('dialog').getByRole('button', { name: 'Cancel' }).click()
+ await this.page
+ .getByRole('dialog')
+ .getByRole('button', { name: 'Finish later', exact: true })
+ .click()
await expect(this.page.getByRole('dialog')).toHaveCount(0)
}