Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): r8-l3 align stream frame size with desktop

Josuée52b2b3c740f
diff --git a/control-ui/components/GfsBrowser.tsx b/control-ui/components/GfsBrowser.tsx
index 80496ebfb..e624195f7 100644
--- a/control-ui/components/GfsBrowser.tsx
+++ b/control-ui/components/GfsBrowser.tsx
@@ -43,6 +43,7 @@ import {
} from '@lib/api'
import { createCoalescedRevalidation } from '@lib/coalescedRevalidation'
import {
+ ENTITY_CHANGE_MAX_FRAME_CHARS,
entityChangeStreamUrl,
parseEntityChangeFrame,
parseEntityChangeRetryAfterMs,
@@ -1103,8 +1104,6 @@ export function GfsBrowser(): React.JSX.Element {
const { done, value } = await reader.read()
if (done) break
pending += decoder.decode(value, { stream: true })
- if (pending.length > 32 * 1024)
- throw new Error('Entity-change frame exceeded its limit')
let newline = pending.indexOf('\n')
while (newline >= 0) {
const line = pending.slice(0, newline).replace(/\r$/, '')
@@ -1129,6 +1128,9 @@ export function GfsBrowser(): React.JSX.Element {
}
newline = pending.indexOf('\n')
}
+ if (pending.length > ENTITY_CHANGE_MAX_FRAME_CHARS) {
+ throw new Error('Entity-change frame exceeded its limit')
+ }
}
} finally {
liveness.dispose()
diff --git a/control-ui/components/__tests__/GfsBrowser.revalidation.integration.test.tsx b/control-ui/components/__tests__/GfsBrowser.revalidation.integration.test.tsx
index 40444022c..ed9bd36ea 100644
--- a/control-ui/components/__tests__/GfsBrowser.revalidation.integration.test.tsx
+++ b/control-ui/components/__tests__/GfsBrowser.revalidation.integration.test.tsx
@@ -255,7 +255,7 @@ describe('GfsBrowser authoritative revalidation integration', () => {
expect(screen.getByRole('button', { name: 'kept.txt' })).toBeVisible()
})
- it('cancels a rejected stream reader before reconnecting after an unsupported schema', async () => {
+ it('rejects an oversized valid frame before reconnecting', async () => {
vi.spyOn(Math, 'random').mockReturnValue(0)
let streamAttempts = 0
let streamCancellations = 0
@@ -318,7 +318,12 @@ describe('GfsBrowser authoritative revalidation integration', () => {
await act(async () => {
streamControllers[0]!.enqueue(
new TextEncoder().encode(
- '{"schemaVersion":2,"type":"future.frame","cursor":"d119f895-1ef8-4e73-8f08-f9754919682a"}\n'
+ `${JSON.stringify({
+ schemaVersion: 1,
+ type: 'heartbeat',
+ cursor: 'd119f895-1ef8-4e73-8f08-f9754919682a',
+ observedAt: 'x'.repeat(17 * 1024),
+ })}\n`
)
)
})
diff --git a/control-ui/lib/__tests__/entityChangeStream.test.ts b/control-ui/lib/__tests__/entityChangeStream.test.ts
index 6c7466c54..1ae155418 100644
--- a/control-ui/lib/__tests__/entityChangeStream.test.ts
+++ b/control-ui/lib/__tests__/entityChangeStream.test.ts
@@ -1,5 +1,9 @@
import { describe, expect, it } from 'vitest'
-import { parseEntityChangeFrame, parseEntityChangeRetryAfterMs } from '../entityChangeStream'
+import {
+ ENTITY_CHANGE_MAX_FRAME_CHARS,
+ parseEntityChangeFrame,
+ parseEntityChangeRetryAfterMs,
+} from '../entityChangeStream'
const CURSOR = 'a20c37c5-d996-48b0-8f49-a8e2f5f41234'
@@ -66,6 +70,17 @@ describe('parseEntityChangeFrame', () => {
parseEntityChangeFrame(JSON.stringify({ schemaVersion: 1, type: 'heartbeat', cursor: '1' }))
).toThrow('Invalid entity-change cursor')
})
+
+ it('rejects frames above the shared Desktop and Control UI limit', () => {
+ const oversized = JSON.stringify({
+ schemaVersion: 1,
+ type: 'heartbeat',
+ cursor: CURSOR,
+ observedAt: 'x'.repeat(ENTITY_CHANGE_MAX_FRAME_CHARS),
+ })
+ expect(oversized.length).toBeGreaterThan(ENTITY_CHANGE_MAX_FRAME_CHARS)
+ expect(() => parseEntityChangeFrame(oversized)).toThrow('frame exceeded its limit')
+ })
})
describe('parseEntityChangeRetryAfterMs', () => {
diff --git a/control-ui/lib/entityChangeStream.ts b/control-ui/lib/entityChangeStream.ts
index 46ce4e076..905ba3e55 100644
--- a/control-ui/lib/entityChangeStream.ts
+++ b/control-ui/lib/entityChangeStream.ts
@@ -2,6 +2,7 @@ import { controlApiUrl } from './api'
export const ENTITY_CHANGE_CURSOR_RE =
/^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i
+export const ENTITY_CHANGE_MAX_FRAME_CHARS = 16 * 1024
export type EntityChangeFrame = {
schemaVersion: 1
@@ -37,6 +38,9 @@ export function parseEntityChangeRetryAfterMs(
/** Parse one NDJSON frame. Safe v1 extensions are skipped; unsupported schemas are rejected. */
export function parseEntityChangeFrame(line: string): EntityChangeFrame | null {
+ if (line.length > ENTITY_CHANGE_MAX_FRAME_CHARS) {
+ throw new Error('Entity-change frame exceeded its limit')
+ }
if (!line.trim()) return null
let value: unknown
try {
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index e999ef66b..991764416 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.697",
+ "version": "0.1.698",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.697",
+ "version": "0.1.698",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 18feeeada..44cbca8b8 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.697",
+ "version": "0.1.698",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",