Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(frontend): disable unavailable row action menus

Josuée6712a49124f
diff --git a/control-ui/components/__tests__/FrontendComponents.test.tsx b/control-ui/components/__tests__/FrontendComponents.test.tsx
index 0ac7d83e8..d1894ffa3 100644
--- a/control-ui/components/__tests__/FrontendComponents.test.tsx
+++ b/control-ui/components/__tests__/FrontendComponents.test.tsx
@@ -209,4 +209,22 @@ describe('shared frontend components', () => {
expect(onDelete).toHaveBeenCalledOnce()
expect(screen.queryByRole('menu')).not.toBeInTheDocument()
})
+
+ it('disables the trigger when every row action is unavailable', () => {
+ const onDelete = vi.fn()
+ render(
+ <RowActionMenu
+ ariaLabel="Actions for Alpha"
+ actions={[
+ { key: 'delete', label: 'Delete', danger: true, disabled: true, onSelect: onDelete },
+ ]}
+ />
+ )
+
+ const trigger = screen.getByRole('button', { name: 'Actions for Alpha' })
+ expect(trigger).toBeDisabled()
+ fireEvent.click(trigger)
+ expect(screen.queryByRole('menu')).not.toBeInTheDocument()
+ expect(onDelete).not.toHaveBeenCalled()
+ })
})
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index 561be2520..f9ac708d9 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.552",
+ "version": "0.1.553",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.552",
+ "version": "0.1.553",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index c4a858a9f..93f4f2f24 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.552",
+ "version": "0.1.553",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/packages/frontend-components/src/index.tsx b/packages/frontend-components/src/index.tsx
index 02cd03d04..1e8988b31 100644
--- a/packages/frontend-components/src/index.tsx
+++ b/packages/frontend-components/src/index.tsx
@@ -394,12 +394,17 @@ export function RowActionMenu({
const menuRef = useRef<HTMLDivElement>(null)
const initialFocusRef = useRef<'first' | 'last'>('first')
const [position, setPosition] = useState<{ left: number; top: number } | null>(null)
+ const triggerDisabled = actions.every(action => action.disabled)
const close = useCallback((restoreFocus = false) => {
setOpen(false)
if (restoreFocus) triggerRef.current?.focus()
}, [])
+ useEffect(() => {
+ if (triggerDisabled && open) close()
+ }, [close, open, triggerDisabled])
+
useEffect(() => {
if (!open) return
const onPointer = (event: MouseEvent) => {
@@ -453,6 +458,7 @@ export function RowActionMenu({
aria-haspopup="menu"
aria-label={ariaLabel}
className="eft-row-actions__trigger"
+ disabled={triggerDisabled}
onClick={event => {
event.stopPropagation()
initialFocusRef.current = 'first'