Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test(hcc): pin extra Role privilege as a write (#460)

Alfredo Lopezee1b5f943071
diff --git a/host-context-controller/package-lock.json b/host-context-controller/package-lock.json
index 6bf7bdca1..0b28c1870 100644
--- a/host-context-controller/package-lock.json
+++ b/host-context-controller/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.258",
+ "version": "0.1.259",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-host-context-controller",
- "version": "0.1.258",
+ "version": "0.1.259",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"@clerum/image-policy": "file:../packages/image-policy",
diff --git a/host-context-controller/package.json b/host-context-controller/package.json
index e041cde2c..e07c3453f 100644
--- a/host-context-controller/package.json
+++ b/host-context-controller/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-host-context-controller",
- "version": "0.1.258",
+ "version": "0.1.259",
"description": "Host Context Controller - provides McpServer CRDs to mcp-host via REST API",
"main": "dist/main.js",
"engines": {
diff --git a/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts b/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts
index 45bb2ddc3..e8df899b4 100644
--- a/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts
+++ b/host-context-controller/src/__tests__/hostRoleNoopGate.test.ts
@@ -112,4 +112,51 @@ describe('Host ensureHostRole no-op gate', () => {
log.mockRestore()
}
})
+
+ it('NOOP-ROLE-3: extra live rule still replaces once', async () => {
+ rbacApi.createNamespacedRole.mockRejectedValue({ code: 409 })
+ let existing: k8s.V1Role | undefined
+ rbacApi.readNamespacedRole.mockImplementation(() => {
+ const live = structuredClone(desiredFromCreate(rbacApi))
+ live.rules = [...(live.rules ?? []), { apiGroups: [''], resources: ['pods'], verbs: ['get'] }]
+ existing = asApiserverRole(live)
+ return Promise.resolve(existing)
+ })
+ const log = vi.spyOn(console, 'log')
+ try {
+ await (reconciler as any).ensureHostRole(host)
+ expect(existing?.rules?.length).toBe((desiredFromCreate(rbacApi).rules?.length ?? 0) + 1)
+ expect(rbacApi.replaceNamespacedRole).toHaveBeenCalledOnce()
+ expect(updatedRoleLogs(log, '"host-chatllm-config-reader"')).toEqual([
+ '[HostReconciler] Updated Role "host-chatllm-config-reader"',
+ ])
+ } finally {
+ log.mockRestore()
+ }
+ })
+
+ it('NOOP-ROLE-4: extra live secret verb still replaces once', async () => {
+ rbacApi.createNamespacedRole.mockRejectedValue({ code: 409 })
+ let existing: k8s.V1Role | undefined
+ rbacApi.readNamespacedRole.mockImplementation(() => {
+ const live = structuredClone(desiredFromCreate(rbacApi))
+ const secretRule = live.rules?.find(
+ (rule: k8s.V1PolicyRule) => rule.resources?.[0] === 'secrets' && rule.verbs?.includes('get')
+ )
+ secretRule!.verbs = [...(secretRule!.verbs ?? []), 'update']
+ existing = asApiserverRole(live)
+ return Promise.resolve(existing)
+ })
+ const log = vi.spyOn(console, 'log')
+ try {
+ await (reconciler as any).ensureHostRole(host)
+ expect(existing?.rules?.some(rule => rule.verbs?.includes('update'))).toBe(true)
+ expect(rbacApi.replaceNamespacedRole).toHaveBeenCalledOnce()
+ expect(updatedRoleLogs(log, '"host-chatllm-config-reader"')).toEqual([
+ '[HostReconciler] Updated Role "host-chatllm-config-reader"',
+ ])
+ } finally {
+ log.mockRestore()
+ }
+ })
})