Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

docs(workflow-recipes): document applyGate read-failure and GFS spec compare

Alfredo Lopezeeac475c476b
diff --git a/workflow-recipes/package-lock.json b/workflow-recipes/package-lock.json
index babf05655..3a7c19686 100644
--- a/workflow-recipes/package-lock.json
+++ b/workflow-recipes/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "workload-recipes-controller",
- "version": "0.1.366",
+ "version": "0.1.367",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "workload-recipes-controller",
- "version": "0.1.366",
+ "version": "0.1.367",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"@aws-sdk/client-s3": "^3.1009.0",
diff --git a/workflow-recipes/package.json b/workflow-recipes/package.json
index 24f71133c..0fd1f05c6 100644
--- a/workflow-recipes/package.json
+++ b/workflow-recipes/package.json
@@ -1,6 +1,6 @@
{
"name": "workload-recipes-controller",
- "version": "0.1.366",
+ "version": "0.1.367",
"description": "Workload Recipes Controller (WRC) - WorkloadRecipe lifecycle management and MCP server interface",
"main": "dist/main.js",
"engines": {
diff --git a/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts b/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts
index 38aa7dbfe..8acb63a65 100644
--- a/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts
+++ b/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts
@@ -4150,8 +4150,11 @@ export class WorkflowRecipeReconciler {
*
* A read failure that carries an apiserver status or a transport signature
* returns `changed` — never skip an update we cannot prove is unnecessary.
- * Any other failure is not a read outcome but a domain or programming error,
- * and it propagates instead of turning into a silent overwrite.
+ * The caller then goes straight to the replace, not to a create first: after
+ * a 403 on the read, the PUT usually fails with 403 as well and that error
+ * propagates like any other failed write. Any other failure is not a read
+ * outcome but a domain or programming error, and it propagates instead of
+ * turning into a silent overwrite.
*/
private async applyGate(idempotency: {
manifest: GatedManifest
@@ -5983,7 +5986,10 @@ export class WorkflowRecipeReconciler {
([key, value]) => existingLabels[key] === value
)
// client-node rebuilds a read object in its own key order, so the spec
- // comparison must not depend on key order.
+ // comparison must not depend on key order. Comparing the whole spec is
+ // safe only while the builder sets every field the apiserver defaults
+ // (`policyTypes`, `ports[].protocol`); otherwise every pass would PUT.
+ // networkPolicyFactory.gfs.test.ts pins the builder's full spec.
return labelsMatch && this.equalComparable(existing.spec, policy.spec)
}
const replaceWith = (existing: k8s.V1NetworkPolicy) => {