Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): simplify connector table columns

Josuéf0dcd5784334
diff --git a/control-ui/components/McpServerTable.tsx b/control-ui/components/McpServerTable.tsx
index 967fe1712..9c516837d 100644
--- a/control-ui/components/McpServerTable.tsx
+++ b/control-ui/components/McpServerTable.tsx
@@ -2,7 +2,6 @@
import React, { useMemo, useState } from 'react'
import { DataTable, TableRow, TableStateRow, TruncatedText } from '@clerum/frontend-components'
-import { copyTextToClipboard } from '@lib/clipboard'
import type {
ConnectorContextBinding,
McpServerStatus,
@@ -15,20 +14,19 @@ import { IconCable } from './Sidebar/icons'
import { TableHeaderRow } from './TableHeaderRow'
import type { TableHeaderColumn } from './TableHeaderRow/types'
import { TablePanelHeader } from './TablePanelHeader'
-import { IconCopy, IconRefresh, IconX } from './icons'
+import { IconRefresh, IconX } from './icons'
const ENABLED_TOOLTIP = 'Enabled controls whether this server is available to contexts and agents.'
-type ConnectorSortKey = 'name' | 'description' | 'endpoint' | 'managed' | 'enabled' | 'status'
+type ConnectorSortKey = 'name' | 'description' | 'managed' | 'enabled' | 'status'
type SortDirection = 'asc' | 'desc'
const CONNECTOR_COLUMNS: TableHeaderColumn[] = [
- { key: 'name', label: 'Name' },
+ { key: 'name', label: 'Name', width: '24%' },
{ key: 'description', label: 'Description' },
- { key: 'endpoint', label: 'Endpoint' },
- { key: 'managed', label: 'Managed' },
- { key: 'enabled', label: 'Enabled', title: ENABLED_TOOLTIP },
- { key: 'status', label: 'Status' },
- { key: 'actions', align: 'right', ariaLabel: 'Actions' },
+ { key: 'managed', label: 'Managed', width: '6rem' },
+ { key: 'enabled', label: 'Enabled', title: ENABLED_TOOLTIP, width: '6rem' },
+ { key: 'status', label: 'Status', width: '7rem' },
+ { key: 'actions', align: 'right', ariaLabel: 'Actions', width: '3.5rem' },
]
function BoolBadge({
@@ -81,50 +79,6 @@ function StatusBadge({ status }: { status?: McpServerStatus }) {
)
}
-function CopyableValue({
- copyLabel,
- copied,
- href,
- onCopy,
- value,
-}: {
- copyLabel: string
- copied: boolean
- href?: string
- onCopy: () => void
- value: string
-}) {
- if (!value) return <span className="cu-muted">—</span>
- return (
- <span className="cu-copy-field">
- {href ? (
- <a
- className="cu-copy-field__value cu-link cu-cell-truncate"
- href={href}
- rel="noreferrer"
- target="_blank"
- title={value}
- >
- {value}
- </a>
- ) : (
- <span className="cu-copy-field__value cu-cell-truncate" title={value}>
- {value}
- </span>
- )}
- <button
- aria-label={copied ? `${copyLabel} copied` : `Copy ${copyLabel}`}
- className="cu-btn cu-btn--icon cu-btn--ghost"
- onClick={onCopy}
- title={copied ? 'Copied' : `Copy ${copyLabel}`}
- type="button"
- >
- <IconCopy height={14} width={14} />
- </button>
- </span>
- )
-}
-
export function McpServerTable({
items,
accessByConnectorKey,
@@ -149,7 +103,6 @@ export function McpServerTable({
const [serverKeyAddingContexts, setServerKeyAddingContexts] = useState<string | null>(null)
const [serverKeyViewingAccess, setServerKeyViewingAccess] = useState<string | null>(null)
const [selectedContextNamesToAdd, setSelectedContextNamesToAdd] = useState<string[]>([])
- const [copiedValueKey, setCopiedValueKey] = useState<string | null>(null)
const accessDialogRef = React.useRef<HTMLElement | null>(null)
const accessCloseButtonRef = React.useRef<HTMLButtonElement | null>(null)
const accessOpenerRef = React.useRef<HTMLElement | null>(null)
@@ -206,19 +159,13 @@ export function McpServerTable({
undefined,
{ sensitivity: 'base' }
)
- : sortKey === 'endpoint'
- ? (left.item.spec?.transport?.url ?? left.item.spec?.image ?? '').localeCompare(
- right.item.spec?.transport?.url ?? right.item.spec?.image ?? ''
- )
- : sortKey === 'managed'
- ? Number((left.item.spec?.managed ?? true) === true) -
- Number((right.item.spec?.managed ?? true) === true)
- : sortKey === 'enabled'
- ? Number((left.item.spec?.enabled ?? true) === true) -
- Number((right.item.spec?.enabled ?? true) === true)
- : getStatusLabel(left.item.status).localeCompare(
- getStatusLabel(right.item.status)
- )
+ : sortKey === 'managed'
+ ? Number((left.item.spec?.managed ?? true) === true) -
+ Number((right.item.spec?.managed ?? true) === true)
+ : sortKey === 'enabled'
+ ? Number((left.item.spec?.enabled ?? true) === true) -
+ Number((right.item.spec?.enabled ?? true) === true)
+ : getStatusLabel(left.item.status).localeCompare(getStatusLabel(right.item.status))
if (comparison !== 0) return comparison * direction
return left.key.localeCompare(right.key)
})
@@ -300,10 +247,6 @@ export function McpServerTable({
setServerKeyAddingContexts(null)
}
- async function copyValue(copyKey: string, value: string) {
- if (await copyTextToClipboard(value)) setCopiedValueKey(copyKey)
- }
-
function openAccessDetails(key: string) {
accessOpenerRef.current =
document.activeElement instanceof HTMLElement ? document.activeElement : null
@@ -409,17 +352,6 @@ export function McpServerTable({
<td className="cu-registry-description">
<TruncatedText value={spec.description} />
</td>
- <td className="cu-code-text">
- <CopyableValue
- copied={copiedValueKey === `${key}/endpoint`}
- copyLabel="endpoint"
- href={spec.transport?.url}
- onCopy={() =>
- void copyValue(`${key}/endpoint`, spec.transport?.url || spec.image || '')
- }
- value={spec.transport?.url || spec.image || ''}
- />
- </td>
<td>
<BoolBadge value={spec.managed} trueLabel="Yes" falseLabel="No" />
</td>
diff --git a/control-ui/components/__tests__/McpServerTable.test.tsx b/control-ui/components/__tests__/McpServerTable.test.tsx
index 097c4b825..7a10cf7e4 100644
--- a/control-ui/components/__tests__/McpServerTable.test.tsx
+++ b/control-ui/components/__tests__/McpServerTable.test.tsx
@@ -333,31 +333,15 @@ describe('McpServerTable — connector access summaries', () => {
expect(trigger).toHaveFocus()
})
- it('keeps connector endpoint links and copy actions available', async () => {
+ it('keeps connector endpoints searchable after removing the visible endpoint column', () => {
const onEdit = vi.fn()
- const writeText = vi.fn().mockResolvedValue(undefined)
- Object.defineProperty(navigator, 'clipboard', {
- configurable: true,
- value: { writeText },
- })
render(<McpServerTable items={[makeItem({ name: 'airtable-server' })]} onEdit={onEdit} />)
- const endpointLink = screen.getByRole('link', { name: /brave-search\.mcp-server/ })
- expect(endpointLink).toHaveAttribute(
- 'href',
- 'http://brave-search.mcp-server.svc.cluster.local:3000/mcp'
- )
- fireEvent.click(endpointLink)
- fireEvent.keyDown(endpointLink, { key: 'Enter' })
- const copyButton = screen.getByRole('button', { name: 'Copy endpoint' })
- fireEvent.click(copyButton)
- fireEvent.keyDown(copyButton, { key: 'Enter' })
- await waitFor(() =>
- expect(writeText).toHaveBeenCalledWith(
- 'http://brave-search.mcp-server.svc.cluster.local:3000/mcp'
- )
- )
- expect(screen.getByRole('button', { name: 'endpoint copied' })).toBeInTheDocument()
+ expect(screen.queryByRole('columnheader', { name: /Endpoint/i })).toBeNull()
+ fireEvent.change(screen.getByLabelText('Search connectors'), {
+ target: { value: 'brave-search.mcp-server' },
+ })
+ expect(screen.getByText('airtable-server')).toBeInTheDocument()
expect(onEdit).not.toHaveBeenCalled()
})
@@ -378,12 +362,12 @@ describe('McpServerTable — connector access summaries', () => {
const url = 'http://brave-search.mcp-server.svc.cluster.local:3000/mcp'
render(<McpServerTable items={[makeItem({ name: 'airtable-server', image })]} />)
- expect(screen.getByRole('columnheader', { name: /Endpoint/i })).toBeInTheDocument()
+ expect(screen.queryByRole('columnheader', { name: /Endpoint/i })).toBeNull()
expect(screen.queryByRole('columnheader', { name: /Image/i })).toBeNull()
expect(screen.queryByRole('columnheader', { name: /Transport/i })).toBeNull()
expect(screen.queryByRole('columnheader', { name: /Access/i })).toBeNull()
expect(screen.getByRole('columnheader', { name: /Managed/i })).toBeInTheDocument()
- expect(screen.getByTitle(url)).toBeInTheDocument()
+ expect(screen.queryByTitle(url)).toBeNull()
expect(screen.queryByTitle(image)).toBeNull()
})
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index cbdf735cf..829f19677 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.526",
+ "version": "0.1.527",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.526",
+ "version": "0.1.527",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 741b106cb..682800405 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.526",
+ "version": "0.1.527",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",