Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(control-ui): preview direct agent grants

Miguelon Peluchonf0f72dd269b6
diff --git a/control-ui/components/CreateMcpServerForm/index.tsx b/control-ui/components/CreateMcpServerForm/index.tsx
index efe43004c..3e0b01ad8 100644
--- a/control-ui/components/CreateMcpServerForm/index.tsx
+++ b/control-ui/components/CreateMcpServerForm/index.tsx
@@ -12,9 +12,9 @@ import {
createMcpSecret,
createMcpServer,
deleteMcpSecret,
+ getAgentTeams,
+ getAgentUsers,
getContext,
- getContextTeams,
- getContextUsers,
getHosts,
listOrgImages,
updateContext,
@@ -317,7 +317,7 @@ export function CreateMcpServerForm({
)
useEffect(() => {
- if (selectedContextRefs.length === 0) {
+ if (selectedAgentNames.length === 0) {
setAccessPreview(EMPTY_ACCESS_PREVIEW)
setAccessPreviewError('')
setLoadingAccessPreview(false)
@@ -330,10 +330,10 @@ export function CreateMcpServerForm({
void (async () => {
const results = await Promise.all(
- selectedContextRefs.map(async contextRef => {
+ selectedAgentNames.map(async agentName => {
const [usersResult, teamsResult] = await Promise.allSettled([
- getContextUsers(contextRef),
- getContextTeams(contextRef),
+ getAgentUsers(agentName),
+ getAgentTeams(agentName),
])
return { usersResult, teamsResult }
})
@@ -379,7 +379,7 @@ export function CreateMcpServerForm({
return () => {
cancelled = true
}
- }, [selectedContextRefs])
+ }, [selectedAgentNames])
useEffect(() => {
let cancelled = false
diff --git a/control-ui/components/__tests__/CreateMcpServerForm.test.tsx b/control-ui/components/__tests__/CreateMcpServerForm.test.tsx
index 64ba8ddd9..872f45456 100644
--- a/control-ui/components/__tests__/CreateMcpServerForm.test.tsx
+++ b/control-ui/components/__tests__/CreateMcpServerForm.test.tsx
@@ -16,6 +16,8 @@ vi.mock('../../lib/api', async () => {
createMcpServer: vi.fn().mockResolvedValue({ metadata: { name: 'test-server' } }),
createMcpSecret: vi.fn().mockResolvedValue({ name: 'test-credentials' }),
deleteMcpSecret: vi.fn().mockResolvedValue({ name: 'test-credentials' }),
+ getAgentTeams: vi.fn().mockResolvedValue({ items: [] }),
+ getAgentUsers: vi.fn().mockResolvedValue({ items: [] }),
// The form no longer reads the context list; kept as a spy to lock that contract.
getContexts: vi.fn(),
getContext: vi.fn().mockResolvedValue(context1),
@@ -169,10 +171,10 @@ describe('CreateMcpServerForm — render', () => {
})
it('previews who can use the connector for selected agents', async () => {
- vi.mocked(api.getContextUsers).mockResolvedValueOnce({
+ vi.mocked(api.getAgentUsers).mockResolvedValueOnce({
items: [{ id: 'user-1', displayName: 'Josue', email: '[email protected]', name: 'josue' }],
})
- vi.mocked(api.getContextTeams).mockResolvedValueOnce({
+ vi.mocked(api.getAgentTeams).mockResolvedValueOnce({
items: [{ id: 'team-1', name: 'Development Team' }],
})
vi.mocked(api.getHosts).mockResolvedValueOnce({
@@ -189,9 +191,11 @@ describe('CreateMcpServerForm — render', () => {
expect(preview).toHaveTextContent('product')
expect(preview).toHaveTextContent('Josue')
expect(preview).toHaveTextContent('Development Team')
- // Users/teams are resolved through the selected agent's scope.
- expect(api.getContextUsers).toHaveBeenCalledWith('context1')
- expect(api.getContextTeams).toHaveBeenCalledWith('context1')
+ // The preview follows direct Agent grants, not legacy Context mappings.
+ expect(api.getAgentUsers).toHaveBeenCalledWith('agents/product')
+ expect(api.getAgentTeams).toHaveBeenCalledWith('agents/product')
+ expect(api.getContextUsers).not.toHaveBeenCalled()
+ expect(api.getContextTeams).not.toHaveBeenCalled()
})
it('hides the advanced options by default and reveals them on toggle', async () => {
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index e39c8dace..7f77b8508 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.492",
+ "version": "0.1.493",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.492",
+ "version": "0.1.493",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/llm-providers": "file:../packages/llm-providers",
diff --git a/control-ui/package.json b/control-ui/package.json
index 7ff33a295..390743529 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.492",
+ "version": "0.1.493",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",