Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

feat(frontend-components): add grouped table disclosure primitive

Josuéf31620fc8140
diff --git a/control-ui/components/__tests__/FrontendComponents.test.tsx b/control-ui/components/__tests__/FrontendComponents.test.tsx
index dfae63538..8a69fbd8d 100644
--- a/control-ui/components/__tests__/FrontendComponents.test.tsx
+++ b/control-ui/components/__tests__/FrontendComponents.test.tsx
@@ -4,6 +4,7 @@ import { readFileSync } from 'node:fs'
import { resolve } from 'node:path'
import {
DataTable,
+ GroupedTableBody,
RowActionMenu,
TableHeaderCell,
TableRow,
@@ -21,6 +22,98 @@ function cssRule(css: string, selector: string) {
}
describe('shared frontend components', () => {
+ it('controls independent accessible grouped table disclosures with semantic rows', () => {
+ const onAlphaExpandedChange = vi.fn()
+ const { rerender } = render(
+ <DataTable>
+ <GroupedTableBody
+ colSpan={2}
+ disclosureLabel={expanded => `${expanded ? 'Collapse' : 'Expand'} Alpha records`}
+ expanded={false}
+ groupId="alpha"
+ onExpandedChange={onAlphaExpandedChange}
+ summary="Alpha"
+ >
+ <tr>
+ <td>Alpha child action</td>
+ <td>
+ <button type="button">Edit Alpha</button>
+ </td>
+ </tr>
+ </GroupedTableBody>
+ <GroupedTableBody
+ colSpan={2}
+ disclosureLabel={expanded => `${expanded ? 'Collapse' : 'Expand'} Beta records`}
+ expanded={false}
+ groupId="beta"
+ onExpandedChange={vi.fn()}
+ summary="Beta"
+ >
+ <tr>
+ <td>Beta child</td>
+ <td />
+ </tr>
+ </GroupedTableBody>
+ </DataTable>
+ )
+
+ const alphaDisclosure = screen.getByRole('button', { name: 'Expand Alpha records' })
+ expect(alphaDisclosure).toHaveAttribute('aria-expanded', 'false')
+ expect(alphaDisclosure).toHaveAttribute('aria-controls', 'eft-table-group-alpha-rows')
+ expect(document.querySelectorAll('table > tbody > tr')).toHaveLength(2)
+ expect(screen.queryByText('Alpha child action')).toBeNull()
+ expect(screen.queryByText('Beta child')).toBeNull()
+
+ fireEvent.click(alphaDisclosure)
+ expect(onAlphaExpandedChange).toHaveBeenCalledWith(true)
+
+ rerender(
+ <DataTable>
+ <GroupedTableBody
+ colSpan={2}
+ disclosureLabel={expanded => `${expanded ? 'Collapse' : 'Expand'} Alpha records`}
+ expanded
+ groupId="alpha"
+ onExpandedChange={onAlphaExpandedChange}
+ summary="Alpha"
+ >
+ <tr>
+ <td>Alpha child action</td>
+ <td>
+ <button type="button">Edit Alpha</button>
+ </td>
+ </tr>
+ </GroupedTableBody>
+ <GroupedTableBody
+ colSpan={2}
+ disclosureLabel={expanded => `${expanded ? 'Collapse' : 'Expand'} Beta records`}
+ expanded={false}
+ groupId="beta"
+ onExpandedChange={vi.fn()}
+ summary="Beta"
+ >
+ <tr>
+ <td>Beta child</td>
+ <td />
+ </tr>
+ </GroupedTableBody>
+ </DataTable>
+ )
+
+ expect(screen.getByRole('button', { name: 'Collapse Alpha records' })).toHaveAttribute(
+ 'aria-expanded',
+ 'true'
+ )
+ expect(screen.getByText('Alpha child action').closest('tr')?.parentElement).toHaveAttribute(
+ 'id',
+ 'eft-table-group-alpha-rows'
+ )
+ expect(screen.queryByText('Beta child')).toBeNull()
+
+ fireEvent.click(screen.getByRole('button', { name: 'Edit Alpha' }))
+ expect(onAlphaExpandedChange).toHaveBeenCalledTimes(1)
+ })
+
it('owns the canonical viewport class and preserves semantic modifiers', () => {
render(
<TableViewport aria-label="Embedded results" className="cu-table-wrap" embedded>
diff --git a/control-ui/package-lock.json b/control-ui/package-lock.json
index e13cd85d9..6e19a7ac7 100644
--- a/control-ui/package-lock.json
+++ b/control-ui/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "clerum-control-ui",
- "version": "0.1.575",
+ "version": "0.1.576",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "clerum-control-ui",
- "version": "0.1.575",
+ "version": "0.1.576",
"dependencies": {
"@clerum/display-field": "file:../packages/display-field",
"@clerum/frontend-components": "file:../packages/frontend-components",
diff --git a/control-ui/package.json b/control-ui/package.json
index 80993b694..3d70dd5e1 100644
--- a/control-ui/package.json
+++ b/control-ui/package.json
@@ -1,6 +1,6 @@
{
"name": "clerum-control-ui",
- "version": "0.1.575",
+ "version": "0.1.576",
"private": true,
"scripts": {
"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",
diff --git a/packages/frontend-components/src/public-api.test.ts b/packages/frontend-components/src/public-api.test.ts
index 362b37c7e..f8526d41a 100644
--- a/packages/frontend-components/src/public-api.test.ts
+++ b/packages/frontend-components/src/public-api.test.ts
@@ -1,6 +1,7 @@
import {
DataTable,
DataViewHeader,
+ GroupedTableBody,
RecordList,
RecordListRow,
RowActionMenu,
@@ -18,6 +19,7 @@ import {
import type {
CellKind,
DataViewHeaderProps,
+ GroupedTableBodyProps,
RowAction,
SortDirection,
SortValue,
@@ -29,6 +31,7 @@ import type {
export const publicRuntimeApi = {
DataTable,
DataViewHeader,
+ GroupedTableBody,
RecordList,
RecordListRow,
RowActionMenu,
@@ -47,6 +50,7 @@ export const publicRuntimeApi = {
export type PublicTypeApi = {
cellKind: CellKind
dataViewHeader: DataViewHeaderProps
+ groupedTableBody: GroupedTableBodyProps
rowAction: RowAction
sortDirection: SortDirection
sortValue: SortValue
diff --git a/packages/frontend-components/src/table/grouped.tsx b/packages/frontend-components/src/table/grouped.tsx
new file mode 100644
index 000000000..f300c10f1
--- /dev/null
+++ b/packages/frontend-components/src/table/grouped.tsx
@@ -0,0 +1,50 @@
+'use client'
+
+import { Fragment } from 'react'
+import type { GroupedTableBodyProps } from './types'
+import { classNames } from './utils'
+
+export function GroupedTableBody({
+ childBodyClassName,
+ children,
+ className,
+ colSpan,
+ disclosureClassName,
+ disclosureLabel,
+ expanded,
+ groupId,
+ onExpandedChange,
+ summary,
+}: GroupedTableBodyProps) {
+ const childRowsId = `eft-table-group-${groupId}-rows`
+
+ return (
+ <Fragment>
+ <tbody className={classNames('eft-table-group', className)}>
+ <tr className="eft-table-group__summary-row">
+ <td colSpan={colSpan}>
+ <button
+ aria-controls={childRowsId}
+ aria-expanded={expanded}
+ aria-label={disclosureLabel(expanded)}
+ className={classNames('eft-table-group__disclosure', disclosureClassName)}
+ onClick={event => {
+ event.stopPropagation()
+ onExpandedChange(!expanded)
+ }}
+ type="button"
+ >
+ <span aria-hidden="true" className="eft-table-group__indicator">
+ ›
+ </span>
+ <span className="eft-table-group__summary">{summary}</span>
+ </button>
+ </td>
+ </tr>
+ </tbody>
+ <tbody className={classNames('eft-table-group__children', childBodyClassName)} id={childRowsId}>
+ {expanded ? children : null}
+ </tbody>
+ </Fragment>
+ )
+}
diff --git a/packages/frontend-components/src/table/index.ts b/packages/frontend-components/src/table/index.ts
index f3e3284f5..2d21d6025 100644
--- a/packages/frontend-components/src/table/index.ts
+++ b/packages/frontend-components/src/table/index.ts
@@ -1,4 +1,5 @@
export * from './primitives'
+export * from './grouped'
export * from './row-actions'
export * from './shell'
export * from './sorting'
diff --git a/packages/frontend-components/src/table/types.ts b/packages/frontend-components/src/table/types.ts
index 6bbc4eed9..c79cc95e9 100644
--- a/packages/frontend-components/src/table/types.ts
+++ b/packages/frontend-components/src/table/types.ts
@@ -30,6 +30,19 @@ export type TableStateRowProps = {
message?: ReactNode
}
+export type GroupedTableBodyProps = {
+ childBodyClassName?: string
+ children: ReactNode
+ className?: string
+ colSpan: number
+ disclosureClassName?: string
+ disclosureLabel: (expanded: boolean) => string
+ expanded: boolean
+ groupId: string
+ onExpandedChange: (expanded: boolean) => void
+ summary: ReactNode
+}
+
export type RowAction = {
key: string
label: string
diff --git a/packages/frontend-components/styles.css b/packages/frontend-components/styles.css
index e2981c4ad..25f2d1a8a 100644
--- a/packages/frontend-components/styles.css
+++ b/packages/frontend-components/styles.css
@@ -154,6 +154,41 @@
.eft-table tbody tr:hover > td {
background: color-mix(in srgb, var(--eft-surface-muted) 55%, transparent);
}
+.eft-table-group__summary-row > td {
+ padding: 0;
+}
+.eft-table-group__disclosure {
+ display: flex;
+ width: 100%;
+ align-items: center;
+ gap: 0.75rem;
+ padding: 0.75rem 1rem;
+ border: 0;
+ background: transparent;
+ color: inherit;
+ cursor: pointer;
+ font: inherit;
+ text-align: left;
+}
+.eft-table-group__disclosure:focus-visible {
+ outline: 2px solid var(--eft-focus);
+ outline-offset: -2px;
+}
+.eft-table-group__indicator {
+ display: inline-flex;
+ flex: 0 0 auto;
+ font-size: 1.25em;
+ transition: transform 160ms ease;
+}
+.eft-table-group__disclosure[aria-expanded='true'] .eft-table-group__indicator {
+ transform: rotate(90deg);
+}
+.eft-table-group__summary {
+ display: flex;
+ min-width: 0;
+ flex: 1;
+ align-items: center;
+}
.eft-table tr[data-selected='true'] > td {
background: color-mix(in srgb, var(--eft-accent) 12%, var(--eft-surface));
}