Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
fix(mcp-host): print underscores as written in PDF and DOCX text
marcotebf87566066042
diff --git a/mcp-host/src/workflow/__tests__/inlineMarkup.test.ts b/mcp-host/src/workflow/__tests__/inlineMarkup.test.tsindex fc48172a5..9bff8d42e 100644--- a/mcp-host/src/workflow/__tests__/inlineMarkup.test.ts+++ b/mcp-host/src/workflow/__tests__/inlineMarkup.test.ts@@ -151,15 +151,9 @@ describe('inline markdown', () => {expect(inlineSpans('**a</b> b**')).toEqual([{ text: 'a b', bold: true }])})- it('reads underscore emphasis, but not an underscore inside a word', () => {- expect(inlineSpans('_one_ and __two__')).toEqual([- { text: 'one', italics: true },- { text: ' and ' },- { text: 'two', bold: true },- ])- expect(inlineSpans('snake_case_name and file_v2_final')).toEqual([- { text: 'snake_case_name and file_v2_final' },- ])+ it('prints underscores as written, so names such as __init__ keep them', () => {+ const text = 'the __init__ method, _private and snake_case_name'+ expect(inlineSpans(text)).toEqual([{ text }])})it('prints a noncharacter the input holds as nothing, not as a style', () => {diff --git a/mcp-host/src/workflow/inlineMarkup.ts b/mcp-host/src/workflow/inlineMarkup.tsindex f65e05365..767c9b84d 100644--- a/mcp-host/src/workflow/inlineMarkup.ts+++ b/mcp-host/src/workflow/inlineMarkup.ts@@ -416,8 +416,12 @@ const ATOM = new RegExp(].join('|'),'g')-/** The characters that may mark emphasis, and the style marks. */-const EMPHASIS_CHAR = /[*_~\uFDD0-\uFDD5]/g+/**+ * The characters that may mark emphasis, and the style marks. An underscore+ * prints as written, as it did before: CommonMark reads __init__ as a bold+ * "init", and names like it are common in the text models write.+ */+const EMPHASIS_CHAR = /[*~\uFDD0-\uFDD5]/gfunction unescapeMarkdown(text: string): string {return text.replace(new RegExp(ESCAPE.source, 'g'), escaped => escaped.slice(1))@@ -466,7 +470,7 @@ function joins(span: InlineSpan, next: InlineSpan): boolean {)}-/** A run of `*`, `_` or `~~` that may open or close emphasis, as CommonMark reads it. */+/** A run of `*` or `~~` that may open or close emphasis, as CommonMark reads it. */interface Delimiter {char: string/** Order among the runs, which bounds the search for an opener. */@@ -525,15 +529,13 @@ function delimiter(source: string, char: string, start: number, end: number): Deconst punctuationAfter = isPunctuation(after)const leftFlanking = !spaceAfter && (!punctuationAfter || spaceBefore || punctuationBefore)const rightFlanking = !spaceBefore && (!punctuationBefore || spaceAfter || punctuationAfter)- // An underscore inside a word, as in snake_case, is not emphasis.- const underscore = char === '_'return {char,index: 0,length: end - start,left: end - start,- canOpen: leftFlanking && (!underscore || !rightFlanking || punctuationBefore),- canClose: rightFlanking && (!underscore || !leftFlanking || punctuationAfter),+ canOpen: leftFlanking,+ canClose: rightFlanking,closes: [],opens: [],}@@ -563,7 +565,7 @@ function scanText(source: string, from: number, to: number, pieces: Piece[]): voif (segment.length > at) pieces.push({ text: segment.slice(at) })}-/** Whether `opener` can close with `closer`, by CommonMark's rule of three for `*` and `_`. */+/** Whether `opener` can close with `closer`, by CommonMark's rule of three for `*`. */function pairs(opener: Delimiter, closer: Delimiter): boolean {if (opener.char !== closer.char || !opener.canOpen) return falseif (closer.char === '~') return true