Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(desktop-app): reset stream backoff on valid frames (r8-m6)

Josuéfac61cbb9725
diff --git a/desktop-app/src/__tests__/appService.entityChanges.test.ts b/desktop-app/src/__tests__/appService.entityChanges.test.ts
index 5f0894479..cba362c6a 100644
--- a/desktop-app/src/__tests__/appService.entityChanges.test.ts
+++ b/desktop-app/src/__tests__/appService.entityChanges.test.ts
@@ -121,6 +121,39 @@ describe('AppService entity-change fan-out', () => {
})
describe('AppService.startEntityChangeStream session expiry', () => {
+ it('does not reset reconnect backoff on synthetic transport-open callbacks', async () => {
+ vi.useFakeTimers()
+ vi.spyOn(Math, 'random').mockReturnValue(0)
+ const service = new AppService() as any
+ setSyntheticSessionToken(service, 'session-token')
+ service.authClient = {
+ openEntityChangeStream: vi.fn(async (_token, _cursor, onEvent) => {
+ onEvent({ type: 'open' })
+ throw new Error('network disconnected before a valid frame')
+ }),
+ }
+
+ try {
+ service.startEntityChangeStream('stream-1', 7, vi.fn())
+ await flushAsyncWork()
+ expect(service.authClient.openEntityChangeStream).toHaveBeenCalledTimes(1)
+
+ await vi.advanceTimersByTimeAsync(1_000)
+ await flushAsyncWork()
+ expect(service.authClient.openEntityChangeStream).toHaveBeenCalledTimes(2)
+
+ await vi.advanceTimersByTimeAsync(1_999)
+ expect(service.authClient.openEntityChangeStream).toHaveBeenCalledTimes(2)
+ await vi.advanceTimersByTimeAsync(1)
+ await flushAsyncWork()
+ expect(service.authClient.openEntityChangeStream).toHaveBeenCalledTimes(3)
+ } finally {
+ service.stopEntityChangeStream('stream-1', 7)
+ vi.useRealTimers()
+ vi.restoreAllMocks()
+ }
+ })
+
it('turns an initial 401 into a terminal session-expired frame without reconnecting', async () => {
const service = new AppService() as any
setSyntheticSessionToken(service, 'session-token')
diff --git a/desktop-app/src/appService.ts b/desktop-app/src/appService.ts
index e6c0c0d1c..1d336b8cc 100644
--- a/desktop-app/src/appService.ts
+++ b/desktop-app/src/appService.ts
@@ -2978,7 +2978,17 @@ export class AppService {
this.entityChangeCursor,
event => {
if (closed) return
- if (event.type === 'open') backoffMs = 1000
+ if (
+ event.type === 'heartbeat' ||
+ event.type === 'scope.invalidated' ||
+ event.type === 'resync_required' ||
+ event.type === 'stream.closing'
+ ) {
+ // Transport-open is synthetic: it proves only that fetch
+ // returned headers. Reset retry pressure only after the server
+ // produces a validated schema-v1 frame.
+ backoffMs = 1000
+ }
if (event.type === 'stream.closing' && event.reason === 'session_expired') {
this.handleEntityChangeSessionExpiry(connectionGeneration)
return