Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

test: require visible login and GFS discovery in natural analysis

Alfredo Lopezfac86f689086
diff --git a/desktop-app/test/e2e-playwright/gfs-agent-large-file-cli.test.ts b/desktop-app/test/e2e-playwright/gfs-agent-large-file-cli.test.ts
index 87ce70e7d..4d1dbdc9f 100644
--- a/desktop-app/test/e2e-playwright/gfs-agent-large-file-cli.test.ts
+++ b/desktop-app/test/e2e-playwright/gfs-agent-large-file-cli.test.ts
@@ -87,6 +87,17 @@ async function sendTaskAndWaitForReviewedShell(
const downloaded = completedToolStepRow(page, /gfs_download|gfs_read/)
let receiptPath: string
if (sourceMode === 'path') {
+ // The user supplied only a human path. An observed discovery result must
+ // precede the transfer; the harness never injects a resourceId into chat.
+ const discovery = completedToolStepRow(page, /gfs_accessible|gfs_list|gfs_search/)
+ expect(await discovery.count()).toBeGreaterThan(0)
+ const steps = await stepper.getByTestId(/^step-row-/).allInnerTexts()
+ const firstDiscovery = steps.findIndex(value =>
+ /gfs_accessible|gfs_list|gfs_search/.test(value)
+ )
+ const firstTransfer = steps.findIndex(value => /gfs_download|gfs_read/.test(value))
+ expect(firstDiscovery).toBeGreaterThanOrEqual(0)
+ expect(firstTransfer).toBeGreaterThan(firstDiscovery)
await expect(downloaded).toHaveCount(1)
const downloadOutput = await stepOutput(downloaded)
await expect(downloadOutput).toContainText('workspace_file')
diff --git a/desktop-app/test/e2e-playwright/workflowUi.ts b/desktop-app/test/e2e-playwright/workflowUi.ts
index 660f70587..caaab68d9 100644
--- a/desktop-app/test/e2e-playwright/workflowUi.ts
+++ b/desktop-app/test/e2e-playwright/workflowUi.ts
@@ -598,23 +598,23 @@ export async function launchAndLogin(
.not.toBe('loading')
const entryState = await readEntryState()
+ // A newly created isolated profile has no session to restore. An already
+ // authenticated shell here is an isolation failure, not a login shortcut.
+ expect(entryState).toBe('login')
if (entryState === 'login') {
await emailInput.fill(email)
await passwordInput.fill(E2E_DESKTOP_PASSWORD)
const signInButton = page.getByRole('button', { name: /^Sign in$/ })
- // A restored session can race the form: the shell may replace the form
- // between fill and click, making the button legitimately disappear.
- // Accept either outcome — click when clickable, and only ever settle on
- // the authenticated shell.
+ await expect(authenticatedShell).not.toBeVisible()
+ await expect(signInButton).toBeVisible()
+ await expect(signInButton).toBeEnabled()
+ await humanUiClick(signInButton)
await expect
.poll(
async () => {
if (await authenticatedShell.isVisible().catch(() => false)) return 'authenticated'
const errorToast = page.getByRole('alert').filter({ hasText: /login|password|failed/i })
if (await errorToast.isVisible().catch(() => false)) return 'error'
- if (await signInButton.isEnabled().catch(() => false)) {
- await humanUiClick(signInButton).catch(() => undefined)
- }
return 'pending'
},
{