Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure
TypeScript
feat(control-ui): show connector create and add-remote as header buttons
Jose Gabriel Ramirez Encinasfae438e0e08f
diff --git a/control-ui/components/McpServerTable.tsx b/control-ui/components/McpServerTable.tsxindex 45c611cfc..466a2e165 100644--- a/control-ui/components/McpServerTable.tsx+++ b/control-ui/components/McpServerTable.tsx@@ -22,6 +22,7 @@ import { TableHeaderRow } from './TableHeaderRow'import type { TableHeaderColumn } from './TableHeaderRow/types'import { TablePanelHeader } from './TablePanelHeader'import { IconRefresh } from './icons'+import { Button } from './ui'const ENABLED_TOOLTIP = 'Enabled controls whether this server is available to agents.'type ConnectorSortKey = 'name' | 'description' | 'managed' | 'enabled' | 'status'@@ -275,35 +276,31 @@ export function McpServerTable({{isInitialLoad ? 'Connectors' : `Connectors (${filteredRows.length})`}</>}- titleActions={+ secondaryActions={onCreate || onAddRemote ? (- <RowActionsMenu- ariaLabel="Connector actions"- horizontalTrigger- actions={[- ...(onCreate- ? [- {- key: 'create',- label: 'Create connector',- onClick: onCreate,- disabled: isInitialLoad,- },- ]- : []),- ...(onAddRemote- ? [- {- key: 'add-remote',- label: 'Add remote server',- onClick: onAddRemote,- disabled: isInitialLoad,- },- ]- : []),- ]}- />- ) : null+ <>+ {onCreate ? (+ <Button+ size="sm"+ className="cu-btn--mcp-install"+ onClick={onCreate}+ disabled={isInitialLoad}+ >+ Create connector+ </Button>+ ) : null}+ {onAddRemote ? (+ <Button+ size="sm"+ className="cu-btn--mcp-install"+ onClick={onAddRemote}+ disabled={isInitialLoad}+ >+ Add remote server+ </Button>+ ) : null}+ </>+ ) : undefined}subtitle="Browse connector deployments and agent access."actionsClassName="cu-table-panel__actions--mcp"diff --git a/control-ui/components/__tests__/McpServerTable.test.tsx b/control-ui/components/__tests__/McpServerTable.test.tsxindex 91457ff6a..67e383964 100644--- a/control-ui/components/__tests__/McpServerTable.test.tsx+++ b/control-ui/components/__tests__/McpServerTable.test.tsx@@ -569,3 +569,62 @@ describe('McpServerTable — row actions kebab', () => {).toBeInTheDocument()})})++// ─────────────────────────────────────────────────────────────────────────────+// Header actions+// ─────────────────────────────────────────────────────────────────────────────+describe('McpServerTable — header actions', () => {+ function renderWithActions(options: { loading?: boolean; empty?: boolean } = {}) {+ const onCreate = vi.fn()+ const onAddRemote = vi.fn()+ const onInstallFromRegistry = vi.fn()+ render(+ <McpServerTable+ items={options.empty ? [] : [makeItem({})]}+ loading={options.loading}+ onCreate={onCreate}+ onAddRemote={onAddRemote}+ onInstallFromRegistry={onInstallFromRegistry}+ />+ )+ return { onCreate, onAddRemote, onInstallFromRegistry }+ }++ it('offers create, add remote and marketplace as header buttons, not a kebab menu', () => {+ const { onCreate, onAddRemote, onInstallFromRegistry } = renderWithActions()++ expect(screen.queryByRole('button', { name: 'Connector actions' })).not.toBeInTheDocument()++ const create = screen.getByRole('button', { name: 'Create connector' })+ const addRemote = screen.getByRole('button', { name: 'Add remote server' })+ const marketplace = screen.getByRole('button', { name: 'Install from Marketplace' })+ // One primary CTA; the other two are secondary buttons of the same size.+ expect(marketplace).toHaveClass('cu-btn--primary')+ for (const secondary of [create, addRemote]) {+ expect(secondary).not.toHaveClass('cu-btn--primary')+ expect(secondary).toHaveClass('cu-btn', 'cu-btn--sm', 'cu-btn--mcp-install')+ }++ fireEvent.click(create)+ fireEvent.click(addRemote)+ fireEvent.click(marketplace)+ expect(onCreate).toHaveBeenCalledTimes(1)+ expect(onAddRemote).toHaveBeenCalledTimes(1)+ expect(onInstallFromRegistry).toHaveBeenCalledTimes(1)+ })++ it('disables every header CTA during the initial load', () => {+ renderWithActions({ loading: true, empty: true })++ for (const name of ['Create connector', 'Add remote server', 'Install from Marketplace']) {+ expect(screen.getByRole('button', { name })).toBeDisabled()+ }+ })++ it('omits a header button whose handler is not provided', () => {+ render(<McpServerTable items={[makeItem({})]} onAddRemote={vi.fn()} />)++ expect(screen.getByRole('button', { name: 'Add remote server' })).toBeInTheDocument()+ expect(screen.queryByRole('button', { name: 'Create connector' })).not.toBeInTheDocument()+ })+})diff --git a/control-ui/e2e/qa-recorder-connector-create-access.spec.ts b/control-ui/e2e/qa-recorder-connector-create-access.spec.tsindex c61deed97..1d150084c 100644--- a/control-ui/e2e/qa-recorder-connector-create-access.spec.ts+++ b/control-ui/e2e/qa-recorder-connector-create-access.spec.ts@@ -35,9 +35,8 @@ async function continueWizard(page: Page): Promise<void> {async function openCreateConnectorWizard(page: Page): Promise<void> {await page.getByRole('link', { name: 'Installed Connectors', exact: true }).click()await expect(page).toHaveURL(/\/connectors$/, { timeout: 20_000 })- // Creation lives behind the "Connector actions" kebab (lowercase c menuitem).- await page.getByRole('button', { name: 'Connector actions' }).click()- await page.getByRole('menuitem', { name: 'Create connector', exact: true }).click()+ // Creation is a header button next to "Add remote server" and the Marketplace CTA.+ await page.getByRole('button', { name: 'Create connector', exact: true }).click()await expect(page).toHaveURL(/\/connectors\/new$/, { timeout: 20_000 })}diff --git a/control-ui/e2e/qa-recorder-connector-edit.spec.ts b/control-ui/e2e/qa-recorder-connector-edit.spec.tsindex 28f9e31d3..f9a51dac0 100644--- a/control-ui/e2e/qa-recorder-connector-edit.spec.ts+++ b/control-ui/e2e/qa-recorder-connector-edit.spec.ts@@ -54,9 +54,8 @@ async function createEmptyContext(page: Page, contextName: string): Promise<voidasync function createDiscoveryConnector(page: Page, connectorName: string): Promise<void> {await page.getByRole('link', { name: 'Installed Connectors', exact: true }).click()await expect(page).toHaveURL(/\/connectors$/, { timeout: 20_000 })- // Creation lives behind the "Connector actions" kebab (lowercase c menuitem).- await page.getByRole('button', { name: 'Connector actions' }).click()- await page.getByRole('menuitem', { name: 'Create connector', exact: true }).click()+ // Creation is a header button next to "Add remote server" and the Marketplace CTA.+ await page.getByRole('button', { name: 'Create connector', exact: true }).click()await expect(page).toHaveURL(/\/connectors\/new$/, { timeout: 20_000 })await page.getByPlaceholder('my-mcp-server').fill(connectorName)diff --git a/control-ui/package-lock.json b/control-ui/package-lock.jsonindex 1d7a14a73..f991f6729 100644--- a/control-ui/package-lock.json+++ b/control-ui/package-lock.json@@ -1,12 +1,12 @@{"name": "clerum-control-ui",- "version": "0.1.707",+ "version": "0.1.708","lockfileVersion": 3,"requires": true,"packages": {"": {"name": "clerum-control-ui",- "version": "0.1.707",+ "version": "0.1.708","dependencies": {"@clerum/display-field": "file:../packages/display-field","@clerum/frontend-components": "file:../packages/frontend-components",diff --git a/control-ui/package.json b/control-ui/package.jsonindex 2d3351c4e..94179ab19 100644--- a/control-ui/package.json+++ b/control-ui/package.json@@ -1,6 +1,6 @@{"name": "clerum-control-ui",- "version": "0.1.707",+ "version": "0.1.708","private": true,"scripts": {"dev": "NEXT_IGNORE_INCORRECT_LOCKFILE=1 next dev",