Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

docs(wrc): answer the round-3 review notes in the run-lane comments

Alfredo Lopezfc3c44a331b9
diff --git a/workflow-recipes/package-lock.json b/workflow-recipes/package-lock.json
index 476422c54..5678735b1 100644
--- a/workflow-recipes/package-lock.json
+++ b/workflow-recipes/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "workload-recipes-controller",
- "version": "0.1.400",
+ "version": "0.1.401",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "workload-recipes-controller",
- "version": "0.1.400",
+ "version": "0.1.401",
"license": "SEE LICENSE IN LICENSE",
"dependencies": {
"@aws-sdk/client-s3": "^3.1009.0",
diff --git a/workflow-recipes/package.json b/workflow-recipes/package.json
index da3cf0c2b..d75ebbbc0 100644
--- a/workflow-recipes/package.json
+++ b/workflow-recipes/package.json
@@ -1,6 +1,6 @@
{
"name": "workload-recipes-controller",
- "version": "0.1.400",
+ "version": "0.1.401",
"description": "Workload Recipes Controller (WRC) - WorkloadRecipe lifecycle management and MCP server interface",
"main": "dist/main.js",
"engines": {
diff --git a/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts b/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts
index d3e6409a1..ded01544c 100644
--- a/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts
+++ b/workflow-recipes/src/reconciler/workflowRecipeReconciler.ts
@@ -2294,7 +2294,10 @@ export class WorkflowRecipeReconciler {
// replace, or conflicted twice) requeues on the backoff path unless the
// phase is `deploying`: nothing bounds how long the deletion or the
// contention lasts. An ownership conflict does not requeue; it waits for
- // an operator and is published as a condition.
+ // an operator and is published as a condition. The SDK-only lane joins
+ // its own TRANSIENT_REQUEUE_BASE_MS term instead; the two bases differ
+ // by lane only because each flag joins that lane's existing requeue
+ // term, and both are 5s.
//
// Known limit: the requeued pass reaches the run-lane apply only while
// the run is still initializing or recovering. Otherwise the
diff --git a/workflow-recipes/src/workflow/workflowReconciler.ts b/workflow-recipes/src/workflow/workflowReconciler.ts
index fc4ba197d..0b593d43e 100644
--- a/workflow-recipes/src/workflow/workflowReconciler.ts
+++ b/workflow-recipes/src/workflow/workflowReconciler.ts
@@ -270,7 +270,9 @@ export const WORKFLOW_OUTPUT_CONDITION_TYPES = new Set([
* policy another controller owns, or `[]` when no policy is owned by another
* controller (a pending retry does not count as a conflict). The result goes in
* `networkPolicyOwnershipConditions`, where `[]` removes a previously published
- * condition and `undefined` keeps it.
+ * condition and `undefined` keeps it. `lastTransitionTime` follows `status`, as
+ * the Kubernetes condition convention has it: a change in the set of
+ * conflicting policies rewrites `message` and keeps the time the conflict began.
*/
export function buildNetworkPolicyOwnershipConditions(
summary: WorkflowNetworkPolicyApplySummary,
@@ -3060,6 +3062,8 @@ export class WorkflowReconciler {
const pruned = await this.applyNetworkPolicyList(policies)
// The refresh rethrows the DNS error after this prune, so this line is the
// only record that a policy still carries the CIDRs the prune meant to drop.
+ // A conflict is warn-logged by applyNetworkPolicy and not published here:
+ // this path runs outside reconcile() and writes no status.
if (pruned.retryPending) {
this.log.error(
'DNS-failure prune left a NetworkPolicy pending a retry; a later refresh retries it',