Skip to content

Evenfire is an intelligence layer platform for running LLM agents that take real actions, on your infrastructure

TypeScript

fix(connectors): correct the revocation-latency copy for shared grants (R1-M8)

Diego Zacariasfed8373ea269
diff --git a/desktop-app/src/__tests__/appService.mcpConnectorDisconnect.test.ts b/desktop-app/src/__tests__/appService.mcpConnectorDisconnect.test.ts
index b368e8f9b..9e9a4b67d 100644
--- a/desktop-app/src/__tests__/appService.mcpConnectorDisconnect.test.ts
+++ b/desktop-app/src/__tests__/appService.mcpConnectorDisconnect.test.ts
@@ -152,6 +152,17 @@ describe('AppService.disconnectMcpServer (spec 11 U4 — destructive revoke)', (
)
})
+ it('does not promise a bounded revocation latency (R1-M8)', async () => {
+ const svc = makeService()
+ await svc.disconnectMcpServer(SERVER, HOST_REF, CTX, { shared: true })
+
+ const opts = mocks.showMessageBox.mock.calls[0]?.[0] as { detail: string }
+ // SHARED grants are exempt from idle eviction, so "a few minutes" is false;
+ // the copy must state it is sweep-driven and not immediate.
+ expect(opts.detail).not.toMatch(/few minutes/i)
+ expect(opts.detail).toContain('revocation sweep')
+ })
+
it('non-shared copy scopes to the user only', async () => {
const svc = makeService()
await svc.disconnectMcpServer(SERVER, HOST_REF, undefined, { shared: false })
diff --git a/desktop-app/src/appService.ts b/desktop-app/src/appService.ts
index 502c81a31..501eab646 100644
--- a/desktop-app/src/appService.ts
+++ b/desktop-app/src/appService.ts
@@ -4678,8 +4678,14 @@ export class AppService {
const { dialog, BrowserWindow } = await import('electron')
const win = BrowserWindow.getFocusedWindow() ?? undefined
const verb = action === 'connect' ? 'Connect' : 'Disconnect'
+ // Revocation is NOT immediate and — critically — has no fixed upper bound for
+ // the shared (oauth-context) flavor: SHARED partitions are exempt from the
+ // 15-min idle eviction (mcp-host), so a live session ends only on the next
+ // grant-revocation sweep, which is fail-open. Don't promise "a few minutes".
const latencyNote =
- action === 'disconnect' ? ' It can take a few minutes to cut active sessions.' : ''
+ action === 'disconnect'
+ ? ' It is not immediate — active sessions end on the next revocation sweep.'
+ : ''
const message = shared ? `${verb} "${server}" for the whole team?` : `${verb} "${server}"?`
const detail = shared
? action === 'connect'