Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: Reduce the scroll debounce timeout to 100ms and update only if offset changes (#3182)

Aakansha Doshi07e71a80718a
diff --git a/src/components/App.tsx b/src/components/App.tsx
index ddaa552efd..cb65a860b0 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -1008,7 +1008,13 @@ class App extends React.Component<ExcalidrawProps, AppState> {
}
private onScroll = debounce(() => {
- this.setState({ ...this.getCanvasOffsets() });
+ const { offsetTop, offsetLeft } = this.getCanvasOffsets();
+ this.setState((state) => {
+ if (state.offsetLeft === offsetLeft && state.offsetTop === offsetTop) {
+ return null;
+ }
+ return { offsetTop, offsetLeft };
+ });
}, SCROLL_TIMEOUT);
// Copy/paste
diff --git a/src/constants.ts b/src/constants.ts
index 2a7c66fb5b..9471135454 100644
--- a/src/constants.ts
+++ b/src/constants.ts
@@ -94,7 +94,7 @@ export const TOUCH_CTX_MENU_TIMEOUT = 500;
export const TITLE_TIMEOUT = 10000;
export const TOAST_TIMEOUT = 5000;
export const VERSION_TIMEOUT = 30000;
-export const SCROLL_TIMEOUT = 500;
+export const SCROLL_TIMEOUT = 100;
export const ZOOM_STEP = 0.1;
diff --git a/src/packages/excalidraw/CHANGELOG.md b/src/packages/excalidraw/CHANGELOG.md
index dd073044f0..5d0d992bcc 100644
--- a/src/packages/excalidraw/CHANGELOG.md
+++ b/src/packages/excalidraw/CHANGELOG.md
@@ -12,6 +12,16 @@ The change should be grouped under one of the below section and must contain PR
Please add the latest change on the top under the correct section.
-->
+## Unreleased
+
+## Excalidraw API
+
+### Fixes
+
+- Reduce the scroll debounce timeout to `100ms` so `offsets` gets updated faster if changed when container scrolled [#3182](https://github.com/excalidraw/excalidraw/pull/3182).
+
+---
+
## 0.4.1
## Excalidraw API