Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: Fix the root cause of `flushSync` flickering (#9791)

Omar Brikaa37ad85cbaf5e
diff --git a/packages/excalidraw/components/canvases/StaticCanvas.tsx b/packages/excalidraw/components/canvases/StaticCanvas.tsx
index 01ce94c431..9e23fa500b 100644
--- a/packages/excalidraw/components/canvases/StaticCanvas.tsx
+++ b/packages/excalidraw/components/canvases/StaticCanvas.tsx
@@ -34,6 +34,13 @@ const StaticCanvas = (props: StaticCanvasProps) => {
const wrapperRef = useRef<HTMLDivElement>(null);
const isComponentMounted = useRef(false);
+ useEffect(() => {
+ props.canvas.style.width = `${props.appState.width}px`;
+ props.canvas.style.height = `${props.appState.height}px`;
+ props.canvas.width = props.appState.width * props.scale;
+ props.canvas.height = props.appState.height * props.scale;
+ }, [props.appState.height, props.appState.width, props.canvas, props.scale]);
+
useEffect(() => {
const wrapper = wrapperRef.current;
if (!wrapper) {
@@ -49,26 +56,6 @@ const StaticCanvas = (props: StaticCanvasProps) => {
canvas.classList.add("excalidraw__canvas", "static");
}
- const widthString = `${props.appState.width}px`;
- const heightString = `${props.appState.height}px`;
- if (canvas.style.width !== widthString) {
- canvas.style.width = widthString;
- }
- if (canvas.style.height !== heightString) {
- canvas.style.height = heightString;
- }
-
- const scaledWidth = props.appState.width * props.scale;
- const scaledHeight = props.appState.height * props.scale;
- // setting width/height resets the canvas even if dimensions not changed,
- // which would cause flicker when we skip frame (due to throttling)
- if (canvas.width !== scaledWidth) {
- canvas.width = scaledWidth;
- }
- if (canvas.height !== scaledHeight) {
- canvas.height = scaledHeight;
- }
-
renderStaticScene(
{
canvas,