Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: Can't toggle penMode off due to missing typecheck in togglePenMode (#7273)

zsviczian3d4ff59f40fa
diff --git a/src/components/App.tsx b/src/components/App.tsx
index 56dc795f4d..8e4ab63552 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -2716,7 +2716,7 @@ class App extends React.Component<AppProps, AppState> {
});
};
- togglePenMode = (force?: boolean) => {
+ togglePenMode = (force: boolean | null) => {
this.setState((prevState) => {
return {
penMode: force ?? !prevState.penMode,
diff --git a/src/components/LayerUI.tsx b/src/components/LayerUI.tsx
index 8b909da236..5c092fea16 100644
--- a/src/components/LayerUI.tsx
+++ b/src/components/LayerUI.tsx
@@ -66,7 +66,7 @@ interface LayerUIProps {
elements: readonly NonDeletedExcalidrawElement[];
onLockToggle: () => void;
onHandToolToggle: () => void;
- onPenModeToggle: () => void;
+ onPenModeToggle: AppClassProperties["togglePenMode"];
showExitZenModeBtn: boolean;
langCode: Language["code"];
renderTopRightUI?: ExcalidrawProps["renderTopRightUI"];
@@ -258,7 +258,7 @@ const LayerUI = ({
<PenModeButton
zenModeEnabled={appState.zenModeEnabled}
checked={appState.penMode}
- onChange={onPenModeToggle}
+ onChange={() => onPenModeToggle(null)}
title={t("toolBar.penMode")}
penDetected={appState.penDetected}
/>
diff --git a/src/components/MobileMenu.tsx b/src/components/MobileMenu.tsx
index bb26fe7136..4299bf8442 100644
--- a/src/components/MobileMenu.tsx
+++ b/src/components/MobileMenu.tsx
@@ -35,7 +35,7 @@ type MobileMenuProps = {
elements: readonly NonDeletedExcalidrawElement[];
onLockToggle: () => void;
onHandToolToggle: () => void;
- onPenModeToggle: () => void;
+ onPenModeToggle: AppClassProperties["togglePenMode"];
renderTopRightUI?: (
isMobile: boolean,
@@ -94,7 +94,7 @@ export const MobileMenu = ({
)}
<PenModeButton
checked={appState.penMode}
- onChange={onPenModeToggle}
+ onChange={() => onPenModeToggle(null)}
title={t("toolBar.penMode")}
isMobile
penDetected={appState.penDetected}