Virtual whiteboard for sketching hand-drawn like diagrams
fix: remove `noreferrer` on internal links (#9452)
David Luzar4a60fe3d2249
diff --git a/.eslintrc.json b/.eslintrc.jsonindex 8263b08a9a..89f8227361 100644--- a/.eslintrc.json+++ b/.eslintrc.json@@ -32,6 +32,12 @@"name": "jotai","message": "Do not import from \"jotai\" directly. Use our app-specific modules (\"editor-jotai\" or \"app-jotai\")."}+ ],+ "react/jsx-no-target-blank": [+ "error",+ {+ "allowReferrer": true+ }]}}diff --git a/excalidraw-app/components/AI.tsx b/excalidraw-app/components/AI.tsxindex 4469d74f66..9a222a968e 100644--- a/excalidraw-app/components/AI.tsx+++ b/excalidraw-app/components/AI.tsx@@ -73,7 +73,7 @@ export const AIComponents = ({</br><div>You can also try <a href="${import.meta.env.VITE_APP_PLUS_LP- }/plus?utm_source=excalidraw&utm_medium=app&utm_content=d2c" target="_blank" rel="noreferrer noopener">Excalidraw+</a> to get more requests.</div>+ }/plus?utm_source=excalidraw&utm_medium=app&utm_content=d2c" target="_blank" rel="noopener">Excalidraw+</a> to get more requests.</div></div></body></html>`,diff --git a/excalidraw-app/components/EncryptedIcon.tsx b/excalidraw-app/components/EncryptedIcon.tsxindex 552e7ca82f..f7d8ca6012 100644--- a/excalidraw-app/components/EncryptedIcon.tsx+++ b/excalidraw-app/components/EncryptedIcon.tsx@@ -10,7 +10,7 @@ export const EncryptedIcon = () => {className="encrypted-icon tooltip"href="https://plus.excalidraw.com/blog/end-to-end-encryption"target="_blank"- rel="noopener noreferrer"+ rel="noopener"aria-label={t("encrypted.link")}><Tooltip label={t("encrypted.tooltip")} long={true}>diff --git a/excalidraw-app/components/ExcalidrawPlusAppLink.tsx b/excalidraw-app/components/ExcalidrawPlusAppLink.tsxindex 76be9a8f07..04cd963022 100644--- a/excalidraw-app/components/ExcalidrawPlusAppLink.tsx+++ b/excalidraw-app/components/ExcalidrawPlusAppLink.tsx@@ -10,7 +10,7 @@ export const ExcalidrawPlusAppLink = () => {import.meta.env.VITE_APP_PLUS_APP}?utm_source=excalidraw&utm_medium=app&utm_content=signedInUserRedirectButton#excalidraw-redirect`}target="_blank"- rel="noreferrer"+ rel="noopener"className="plus-button">Go to Excalidraw+diff --git a/excalidraw-app/tests/__snapshots__/MobileMenu.test.tsx.snap b/excalidraw-app/tests/__snapshots__/MobileMenu.test.tsx.snapindex 77fc147574..53b16c40ff 100644--- a/excalidraw-app/tests/__snapshots__/MobileMenu.test.tsx.snap+++ b/excalidraw-app/tests/__snapshots__/MobileMenu.test.tsx.snap@@ -198,7 +198,7 @@ exports[`Test MobileMenu > should initialize with welcome screen and hide once u<aclass="welcome-screen-menu-item "href="undefined/plus?utm_source=excalidraw&utm_medium=app&utm_content=welcomeScreenGuest"- rel="noreferrer"+ rel="noopener"target="_blank"><divdiff --git a/packages/excalidraw/components/HelpDialog.tsx b/packages/excalidraw/components/HelpDialog.tsxindex 60fc403723..9dd9550aca 100644--- a/packages/excalidraw/components/HelpDialog.tsx+++ b/packages/excalidraw/components/HelpDialog.tsx@@ -21,7 +21,7 @@ const Header = () => (className="HelpDialog__btn"href="https://docs.excalidraw.com"target="_blank"- rel="noopener noreferrer"+ rel="noopener"><div className="HelpDialog__link-icon">{ExternalLinkIcon}</div>{t("helpDialog.documentation")}@@ -30,7 +30,7 @@ const Header = () => (className="HelpDialog__btn"href="https://plus.excalidraw.com/blog"target="_blank"- rel="noopener noreferrer"+ rel="noopener"><div className="HelpDialog__link-icon">{ExternalLinkIcon}</div>{t("helpDialog.blog")}diff --git a/packages/excalidraw/components/PublishLibrary.tsx b/packages/excalidraw/components/PublishLibrary.tsxindex c1db912961..580b909d4b 100644--- a/packages/excalidraw/components/PublishLibrary.tsx+++ b/packages/excalidraw/components/PublishLibrary.tsx@@ -389,7 +389,7 @@ const PublishLibrary = ({<ahref="https://libraries.excalidraw.com"target="_blank"- rel="noopener noreferrer"+ rel="noopener">{el}</a>diff --git a/packages/excalidraw/components/dropdownMenu/DropdownMenuItemLink.tsx b/packages/excalidraw/components/dropdownMenu/DropdownMenuItemLink.tsxindex 1457f5ae79..d4f549c845 100644--- a/packages/excalidraw/components/dropdownMenu/DropdownMenuItemLink.tsx+++ b/packages/excalidraw/components/dropdownMenu/DropdownMenuItemLink.tsx@@ -16,7 +16,7 @@ const DropdownMenuItemLink = ({onSelect,className = "",selected,- rel = "noreferrer",+ rel = "noopener",...rest}: {href: string;@@ -31,11 +31,12 @@ const DropdownMenuItemLink = ({const handleClick = useHandleDropdownMenuItemClick(rest.onClick, onSelect);return (+ // eslint-disable-next-line react/jsx-no-target-blank<a{...rest}href={href}target="_blank"- rel="noreferrer"+ rel={rel || "noopener"}className={getDropdownMenuItemClassName(className, selected)}title={rest.title ?? rest["aria-label"]}onClick={handleClick}diff --git a/packages/excalidraw/components/welcome-screen/WelcomeScreen.Center.tsx b/packages/excalidraw/components/welcome-screen/WelcomeScreen.Center.tsxindex bd9b9e55bc..8f548823e9 100644--- a/packages/excalidraw/components/welcome-screen/WelcomeScreen.Center.tsx+++ b/packages/excalidraw/components/welcome-screen/WelcomeScreen.Center.tsx@@ -78,7 +78,7 @@ const WelcomeScreenMenuItemLink = ({className={`welcome-screen-menu-item ${className}`}href={href}target="_blank"- rel="noreferrer"+ rel="noopener"><WelcomeScreenMenuItemContent icon={icon} shortcut={shortcut}>{children}diff --git a/packages/excalidraw/tests/__snapshots__/excalidraw.test.tsx.snap b/packages/excalidraw/tests/__snapshots__/excalidraw.test.tsx.snapindex bbcc8d7e0b..bb87746c0d 100644--- a/packages/excalidraw/tests/__snapshots__/excalidraw.test.tsx.snap+++ b/packages/excalidraw/tests/__snapshots__/excalidraw.test.tsx.snap@@ -21,7 +21,7 @@ exports[`<Excalidraw/> > <MainMenu/> > should render main menu with host menu it<aclass="dropdown-menu-item dropdown-menu-item-base"href="blog.excalidaw.com"- rel="noreferrer"+ rel="noopener"target="_blank"><div@@ -392,7 +392,7 @@ exports[`<Excalidraw/> > Test UIOptions prop > Test canvasActions > should rendearia-label="GitHub"class="dropdown-menu-item dropdown-menu-item-base"href="https://github.com/excalidraw/excalidraw"- rel="noreferrer"+ rel="noopener"target="_blank"title="GitHub">@@ -426,7 +426,7 @@ exports[`<Excalidraw/> > Test UIOptions prop > Test canvasActions > should rendearia-label="X"class="dropdown-menu-item dropdown-menu-item-base"href="https://x.com/excalidraw"- rel="noreferrer"+ rel="noopener"target="_blank"title="X">@@ -472,7 +472,7 @@ exports[`<Excalidraw/> > Test UIOptions prop > Test canvasActions > should rendearia-label="Discord"class="dropdown-menu-item dropdown-menu-item-base"href="https://discord.gg/UexuTaE"- rel="noreferrer"+ rel="noopener"target="_blank"title="Discord">