Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

Fix middle handles on mobile (#2459)

Christopher Chedeau533815c08144
diff --git a/src/element/transformHandles.ts b/src/element/transformHandles.ts
index 195581eecb..bf837fbeb3 100644
--- a/src/element/transformHandles.ts
+++ b/src/element/transformHandles.ts
@@ -78,7 +78,7 @@ export const getTransformHandlesFromCoords = (
[x1, y1, x2, y2]: Bounds,
angle: number,
zoom: Zoom,
- pointerType: PointerType = "mouse",
+ pointerType: PointerType,
omitSides: { [T in TransformHandleType]?: boolean } = {},
): TransformHandles => {
const size = transformHandleSizes[pointerType];
@@ -160,7 +160,9 @@ export const getTransformHandlesFromCoords = (
};
// We only want to show height handles (all cardinal directions) above a certain size
- const minimumSizeForEightHandles = (5 * size) / zoom.value;
+ // Note: we render using "mouse" size so we should also use "mouse" size for this check
+ const minimumSizeForEightHandles =
+ (5 * transformHandleSizes.mouse) / zoom.value;
if (Math.abs(width) > minimumSizeForEightHandles) {
if (!omitSides.n) {
transformHandles.n = generateTransformHandle(
diff --git a/src/renderer/renderScene.ts b/src/renderer/renderScene.ts
index 0377494242..15b47887c0 100644
--- a/src/renderer/renderScene.ts
+++ b/src/renderer/renderScene.ts
@@ -371,6 +371,7 @@ export const renderScene = (
const transformHandles = getTransformHandles(
locallySelectedElements[0],
sceneState.zoom,
+ "mouse", // when we render we don't know which pointer type so use mouse
);
renderTransformHandles(
context,
@@ -402,7 +403,7 @@ export const renderScene = (
[x1, y1, x2, y2],
0,
sceneState.zoom,
- undefined,
+ "mouse",
OMIT_SIDES_FOR_MULTIPLE_ELEMENTS,
);
renderTransformHandles(context, sceneState, transformHandles, 0);