Virtual whiteboard for sketching hand-drawn like diagrams
fix: Regression in long press context menu closure (#9588)
Márk Tolmács5921ebc416bc
diff --git a/packages/element/tests/linearElementEditor.test.tsx b/packages/element/tests/linearElementEditor.test.tsxindex 1edbce25b1..b8e49c6339 100644--- a/packages/element/tests/linearElementEditor.test.tsx+++ b/packages/element/tests/linearElementEditor.test.tsx@@ -292,7 +292,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`12`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`6`);expect(line.points.length).toEqual(3);expect(line.points).toMatchInlineSnapshot(`@@ -333,7 +333,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`9`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`6`);const midPointsWithRoundEdge = LinearElementEditor.getEditorMidPoints(h.elements[0] as ExcalidrawLinearElement,@@ -394,7 +394,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`12`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`8`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);expect([line.x, line.y]).toEqual([points[0][0] + deltaX,@@ -462,7 +462,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`16`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`8`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);expect(line.points.length).toEqual(5);@@ -513,7 +513,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`12`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`6`);const newPoints = LinearElementEditor.getPointsGlobalCoordinates(line,@@ -554,7 +554,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`12`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`6`);const newPoints = LinearElementEditor.getPointsGlobalCoordinates(line,@@ -602,7 +602,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`18`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`8`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);const newMidPoints = LinearElementEditor.getEditorMidPoints(line,@@ -660,7 +660,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`16`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`8`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);expect(line.points.length).toEqual(5);expect((h.elements[0] as ExcalidrawLinearElement).points)@@ -758,7 +758,7 @@ describe("Test Linear Elements", () => {expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`12`,);- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`6`);const newPoints = LinearElementEditor.getPointsGlobalCoordinates(line,diff --git a/packages/excalidraw/components/App.tsx b/packages/excalidraw/components/App.tsxindex c8f16af9e4..15b5e5b6fd 100644--- a/packages/excalidraw/components/App.tsx+++ b/packages/excalidraw/components/App.tsx@@ -9118,7 +9118,7 @@ class App extends React.Component<AppProps, AppState> {if (selectedELements.length > 1) {this.setState({ selectedLinearElement: null });}- } else {+ } else if (this.state.selectedLinearElement.isDragging) {this.actionManager.executeAction(actionFinalize, "ui", {event: childEvent,});diff --git a/packages/excalidraw/tests/selection.test.tsx b/packages/excalidraw/tests/selection.test.tsxindex 50d3926514..10f4f7ad98 100644--- a/packages/excalidraw/tests/selection.test.tsx+++ b/packages/excalidraw/tests/selection.test.tsx@@ -426,7 +426,7 @@ describe("select single element on the scene", () => {fireEvent.pointerUp(canvas);expect(renderInteractiveScene).toHaveBeenCalledTimes(8);- expect(renderStaticScene).toHaveBeenCalledTimes(7);+ expect(renderStaticScene).toHaveBeenCalledTimes(6);expect(h.state.selectionElement).toBeNull();expect(h.elements.length).toEqual(1);expect(h.state.selectedElementIds[h.elements[0].id]).toBeTruthy();@@ -470,7 +470,7 @@ describe("select single element on the scene", () => {fireEvent.pointerUp(canvas);expect(renderInteractiveScene).toHaveBeenCalledTimes(8);- expect(renderStaticScene).toHaveBeenCalledTimes(7);+ expect(renderStaticScene).toHaveBeenCalledTimes(6);expect(h.state.selectionElement).toBeNull();expect(h.elements.length).toEqual(1);expect(h.state.selectedElementIds[h.elements[0].id]).toBeTruthy();