Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix(editor): do not flicker bbox when drag-creating line midpoint (#11834)

David Luzar5e375b4331fe
diff --git a/packages/element/tests/linearElementEditor.test.tsx b/packages/element/tests/linearElementEditor.test.tsx
index fe910aa5a8..7c79d7fab9 100644
--- a/packages/element/tests/linearElementEditor.test.tsx
+++ b/packages/element/tests/linearElementEditor.test.tsx
@@ -26,7 +26,7 @@ import {
import type { GlobalPoint, LocalPoint } from "@excalidraw/math";
-import { wrapText } from "../src";
+import { hasBoundingBox, wrapText } from "../src";
import * as textElementUtils from "../src/textElement";
import { getBoundTextElementPosition, getBoundTextMaxWidth } from "../src";
import { LinearElementEditor } from "../src";
@@ -220,7 +220,7 @@ describe("Test Linear Elements", () => {
// drag line from midpoint
drag(midpoint, pointFrom(midpoint[0] + delta, midpoint[1] + delta));
expect(renderInteractiveScene.mock.calls.length).toMatchInlineSnapshot(`8`);
- expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`6`);
+ expect(renderStaticScene.mock.calls.length).toMatchInlineSnapshot(`7`);
expect(line.points.length).toEqual(3);
expect(line.points).toMatchInlineSnapshot(`
[
@@ -240,6 +240,53 @@ describe("Test Linear Elements", () => {
`);
});
+ it("should hide the bounding box while creating or dragging a point", () => {
+ const line = createTwoPointerLinearElement("line");
+ const editorInterface = {
+ userAgent: { isMobileDevice: false },
+ } as Parameters<typeof hasBoundingBox>[2];
+
+ fireEvent.pointerDown(interactiveCanvas, {
+ clientX: midpoint[0],
+ clientY: midpoint[1],
+ });
+ fireEvent.pointerMove(interactiveCanvas, {
+ clientX: midpoint[0] + delta,
+ clientY: midpoint[1] + delta,
+ });
+
+ expect(line.points.length).toBe(3);
+ expect(h.state.selectedLinearElement?.isDragging).toBe(true);
+ expect(hasBoundingBox([line], h.state, editorInterface)).toBe(false);
+
+ fireEvent.pointerUp(interactiveCanvas, {
+ clientX: midpoint[0] + delta,
+ clientY: midpoint[1] + delta,
+ });
+
+ const addedPoint = LinearElementEditor.getPointAtIndexGlobalCoordinates(
+ line,
+ 1,
+ h.scene.getNonDeletedElementsMap(),
+ );
+ fireEvent.pointerDown(interactiveCanvas, {
+ clientX: addedPoint[0],
+ clientY: addedPoint[1],
+ });
+ fireEvent.pointerMove(interactiveCanvas, {
+ clientX: addedPoint[0] + 1,
+ clientY: addedPoint[1] + 1,
+ });
+
+ expect(h.state.selectedLinearElement?.isDragging).toBe(true);
+ expect(hasBoundingBox([line], h.state, editorInterface)).toBe(false);
+
+ fireEvent.pointerUp(interactiveCanvas, {
+ clientX: addedPoint[0],
+ clientY: addedPoint[1],
+ });
+ });
+
it("should allow entering and exiting line editor via context menu", () => {
createTwoPointerLinearElement("line");
fireEvent.contextMenu(GlobalTestState.interactiveCanvas, {
diff --git a/packages/excalidraw/components/App.tsx b/packages/excalidraw/components/App.tsx
index b8be5be54f..9d7067331a 100644
--- a/packages/excalidraw/components/App.tsx
+++ b/packages/excalidraw/components/App.tsx
@@ -10624,6 +10624,7 @@ class App extends React.Component<AppProps, AppState> {
initialState: ret.pointerDownState,
selectedPointsIndices: ret.selectedPointsIndices,
segmentMidPointHoveredCoords: null,
+ isDragging: true,
},
});
}