Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

perf(editor): avoid rebuilding id sets on every resize (#12180)

Nicolas Oga84e3f5a40c5f
diff --git a/packages/element/src/binding.ts b/packages/element/src/binding.ts
index 91d6ab4839..36e68dc29e 100644
--- a/packages/element/src/binding.ts
+++ b/packages/element/src/binding.ts
@@ -1541,10 +1541,27 @@ const doesNeedUpdate = (
);
};
+// PERF: callers updating many elements invoke `updateBoundElements()` for each
+// of them with the same `simultaneouslyUpdated` array, so cache the id set
+// per array to avoid rebuilding it on every call (O(n^2) on multi-element
+// transforms)
+const simultaneouslyUpdatedElementIdsCache = new WeakMap<
+ readonly ExcalidrawElement[],
+ ReadonlySet<ExcalidrawElement["id"]>
+>();
+
const getSimultaneouslyUpdatedElementIds = (
simultaneouslyUpdated: readonly ExcalidrawElement[] | undefined,
-): Set<ExcalidrawElement["id"]> => {
- return new Set((simultaneouslyUpdated || []).map((element) => element.id));
+): ReadonlySet<ExcalidrawElement["id"]> => {
+ if (!simultaneouslyUpdated) {
+ return new Set();
+ }
+ let ids = simultaneouslyUpdatedElementIdsCache.get(simultaneouslyUpdated);
+ if (!ids) {
+ ids = new Set(simultaneouslyUpdated.map((element) => element.id));
+ simultaneouslyUpdatedElementIdsCache.set(simultaneouslyUpdated, ids);
+ }
+ return ids;
};
export const getHeadingForElbowArrowSnap = (