Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: update elbow arrow on font size change #8798 (#9002)

Alpluneb8da5065fdc7
diff --git a/packages/excalidraw/actions/actionProperties.tsx b/packages/excalidraw/actions/actionProperties.tsx
index 17b53e3f5d..5c4d7754fe 100644
--- a/packages/excalidraw/actions/actionProperties.tsx
+++ b/packages/excalidraw/actions/actionProperties.tsx
@@ -89,6 +89,7 @@ import type {
FontFamilyValues,
TextAlign,
VerticalAlign,
+ NonDeletedSceneElementsMap,
} from "../element/types";
import { getLanguage, t } from "../i18n";
import { KEYS } from "../keys";
@@ -115,6 +116,7 @@ import {
bindPointToSnapToElementOutline,
calculateFixedPointForElbowArrowBinding,
getHoveredElementForBinding,
+ updateBoundElements,
} from "../element/binding";
import { LinearElementEditor } from "../element/linearElementEditor";
import type { LocalPoint } from "../../math";
@@ -218,33 +220,47 @@ const changeFontSize = (
) => {
const newFontSizes = new Set<number>();
- return {
- elements: changeProperty(
- elements,
- appState,
- (oldElement) => {
- if (isTextElement(oldElement)) {
- const newFontSize = getNewFontSize(oldElement);
- newFontSizes.add(newFontSize);
-
- let newElement: ExcalidrawTextElement = newElementWith(oldElement, {
- fontSize: newFontSize,
- });
- redrawTextBoundingBox(
- newElement,
- app.scene.getContainerElement(oldElement),
- app.scene.getNonDeletedElementsMap(),
- );
+ const updatedElements = changeProperty(
+ elements,
+ appState,
+ (oldElement) => {
+ if (isTextElement(oldElement)) {
+ const newFontSize = getNewFontSize(oldElement);
+ newFontSizes.add(newFontSize);
+
+ let newElement: ExcalidrawTextElement = newElementWith(oldElement, {
+ fontSize: newFontSize,
+ });
+ redrawTextBoundingBox(
+ newElement,
+ app.scene.getContainerElement(oldElement),
+ app.scene.getNonDeletedElementsMap(),
+ );
- newElement = offsetElementAfterFontResize(oldElement, newElement);
+ newElement = offsetElementAfterFontResize(oldElement, newElement);
- return newElement;
- }
+ return newElement;
+ }
+ return oldElement;
+ },
+ true,
+ );
- return oldElement;
- },
- true,
- ),
+ // Update arrow elements after text elements have been updated
+ const updatedElementsMap = arrayToMap(updatedElements);
+ getSelectedElements(elements, appState, {
+ includeBoundTextElement: true,
+ }).forEach((element) => {
+ if (isTextElement(element)) {
+ updateBoundElements(
+ element,
+ updatedElementsMap as NonDeletedSceneElementsMap,
+ );
+ }
+ });
+
+ return {
+ elements: updatedElements,
appState: {
...appState,
// update state only if we've set all select text elements to