Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: consider arrow for bound text element (#6297)

Aakansha Doshibd4424bbe3e8
diff --git a/src/components/App.tsx b/src/components/App.tsx
index 5b9311f8d4..24da7d85ab 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -2767,7 +2767,6 @@ class App extends React.Component<AppProps, AppState> {
);
if (container) {
if (
- isArrowElement(container) ||
hasBoundTextElement(container) ||
!isTransparent(container.backgroundColor) ||
isHittingElementNotConsideringBoundingBox(container, this.state, [
diff --git a/src/element/typeChecks.test.ts b/src/element/typeChecks.test.ts
new file mode 100644
index 0000000000..ab04c29b79
--- /dev/null
+++ b/src/element/typeChecks.test.ts
@@ -0,0 +1,66 @@
+import { API } from "../tests/helpers/api";
+import { hasBoundTextElement } from "./typeChecks";
+
+describe("Test TypeChecks", () => {
+ describe("Test hasBoundTextElement", () => {
+ it("should return true for text bindable containers with bound text", () => {
+ expect(
+ hasBoundTextElement(
+ API.createElement({
+ type: "rectangle",
+ boundElements: [{ type: "text", id: "text-id" }],
+ }),
+ ),
+ ).toBeTruthy();
+
+ expect(
+ hasBoundTextElement(
+ API.createElement({
+ type: "ellipse",
+ boundElements: [{ type: "text", id: "text-id" }],
+ }),
+ ),
+ ).toBeTruthy();
+
+ expect(
+ hasBoundTextElement(
+ API.createElement({
+ type: "arrow",
+ boundElements: [{ type: "text", id: "text-id" }],
+ }),
+ ),
+ ).toBeTruthy();
+
+ expect(
+ hasBoundTextElement(
+ API.createElement({
+ type: "image",
+ boundElements: [{ type: "text", id: "text-id" }],
+ }),
+ ),
+ ).toBeTruthy();
+ });
+
+ it("should return false for text bindable containers without bound text", () => {
+ expect(
+ hasBoundTextElement(
+ API.createElement({
+ type: "freedraw",
+ boundElements: [{ type: "arrow", id: "arrow-id" }],
+ }),
+ ),
+ ).toBeFalsy();
+ });
+
+ it("should return false for non text bindable containers", () => {
+ expect(
+ hasBoundTextElement(
+ API.createElement({
+ type: "freedraw",
+ boundElements: [{ type: "text", id: "text-id" }],
+ }),
+ ),
+ ).toBeFalsy();
+ });
+ });
+});
diff --git a/src/element/typeChecks.ts b/src/element/typeChecks.ts
index a6b6cb2db5..0f13648f96 100644
--- a/src/element/typeChecks.ts
+++ b/src/element/typeChecks.ts
@@ -139,7 +139,7 @@ export const hasBoundTextElement = (
element: ExcalidrawElement | null,
): element is MarkNonNullable<ExcalidrawBindableElement, "boundElements"> => {
return (
- isBindableElement(element) &&
+ isTextBindableContainer(element) &&
!!element.boundElements?.some(({ type }) => type === "text")
);
};