Virtual whiteboard for sketching hand-drawn like diagrams
fix: getDefaultLineHeight should return default font family line height for unknown font (#6399)
Coyoted2b8f4d2f8e7
diff --git a/src/element/textElement.test.ts b/src/element/textElement.test.tsindex aa7df8ee6a..106ed7beab 100644--- a/src/element/textElement.test.ts+++ b/src/element/textElement.test.ts@@ -332,6 +332,12 @@ describe("Test getDefaultLineHeight", () => {//@ts-ignoreexpect(getDefaultLineHeight()).toBe(1.25);});++ it("should return line height using default font family for unknown font", () => {+ const UNKNOWN_FONT = 5;+ expect(getDefaultLineHeight(UNKNOWN_FONT)).toBe(1.25);+ });+it("should return correct line height", () => {expect(getDefaultLineHeight(FONT_FAMILY.Cascadia)).toBe(1.2);});diff --git a/src/element/textElement.ts b/src/element/textElement.tsindex fd501c1414..8b3979133e 100644--- a/src/element/textElement.ts+++ b/src/element/textElement.ts@@ -887,7 +887,7 @@ const DEFAULT_LINE_HEIGHT = {};export const getDefaultLineHeight = (fontFamily: FontFamilyValues) => {- if (fontFamily) {+ if (fontFamily in DEFAULT_LINE_HEIGHT) {return DEFAULT_LINE_HEIGHT[fontFamily];}return DEFAULT_LINE_HEIGHT[DEFAULT_FONT_FAMILY];