Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: mobile context menu won't show on long press (#4741)

zsvicziand450c3658146
diff --git a/src/components/App.tsx b/src/components/App.tsx
index 8d2fc8956e..ef89c64675 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -163,6 +163,7 @@ import {
shouldRotateWithDiscreteAngle,
isArrowKey,
KEYS,
+ isAndroid,
} from "../keys";
import { distance2d, getGridPoint, isPathALoop } from "../math";
import { renderScene } from "../renderer";
@@ -1274,7 +1275,10 @@ class App extends React.Component<AppProps, AppState> {
private onTapStart = (event: TouchEvent) => {
// fix for Apple Pencil Scribble
- event.preventDefault();
+ // On Android, preventing the event would disable contextMenu on tap-hold
+ if (!isAndroid) {
+ event.preventDefault();
+ }
if (!didTapTwice) {
didTapTwice = true;
@@ -1297,6 +1301,9 @@ class App extends React.Component<AppProps, AppState> {
didTapTwice = false;
clearTimeout(tappedTwiceTimer);
}
+ if (isAndroid) {
+ event.preventDefault();
+ }
if (event.touches.length === 2) {
this.setState({
diff --git a/src/keys.ts b/src/keys.ts
index bd20bbb0c6..fc495437d8 100644
--- a/src/keys.ts
+++ b/src/keys.ts
@@ -1,5 +1,6 @@
export const isDarwin = /Mac|iPod|iPhone|iPad/.test(window.navigator.platform);
export const isWindows = /^Win/.test(window.navigator.platform);
+export const isAndroid = /\b(android)\b/i.test(navigator.userAgent);
export const CODES = {
EQUAL: "Equal",