Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: cleanup redrawTextBoundingBox (#6518)

Aakansha Doshidae81c0a2cb8
diff --git a/src/element/textElement.ts b/src/element/textElement.ts
index f01ba3e1b9..339f68b967 100644
--- a/src/element/textElement.ts
+++ b/src/element/textElement.ts
@@ -83,35 +83,25 @@ export const redrawTextBoundingBox = (
boundTextUpdates.baseline = metrics.baseline;
if (container) {
- if (isArrowElement(container)) {
- const centerX = textElement.x + textElement.width / 2;
- const centerY = textElement.y + textElement.height / 2;
- const diffWidth = metrics.width - textElement.width;
- const diffHeight = metrics.height - textElement.height;
- boundTextUpdates.x = centerY - (textElement.height + diffHeight) / 2;
- boundTextUpdates.y = centerX - (textElement.width + diffWidth) / 2;
- } else {
- const containerDims = getContainerDims(container);
- let maxContainerHeight = getMaxContainerHeight(container);
-
- let nextHeight = containerDims.height;
- if (metrics.height > maxContainerHeight) {
- nextHeight = computeContainerDimensionForBoundText(
- metrics.height,
- container.type,
- );
- mutateElement(container, { height: nextHeight });
- maxContainerHeight = getMaxContainerHeight(container);
- updateOriginalContainerCache(container.id, nextHeight);
- }
- const updatedTextElement = {
- ...textElement,
- ...boundTextUpdates,
- } as ExcalidrawTextElementWithContainer;
- const { x, y } = computeBoundTextPosition(container, updatedTextElement);
- boundTextUpdates.x = x;
- boundTextUpdates.y = y;
+ const containerDims = getContainerDims(container);
+ const maxContainerHeight = getMaxContainerHeight(container);
+
+ let nextHeight = containerDims.height;
+ if (metrics.height > maxContainerHeight) {
+ nextHeight = computeContainerDimensionForBoundText(
+ metrics.height,
+ container.type,
+ );
+ mutateElement(container, { height: nextHeight });
+ updateOriginalContainerCache(container.id, nextHeight);
}
+ const updatedTextElement = {
+ ...textElement,
+ ...boundTextUpdates,
+ } as ExcalidrawTextElementWithContainer;
+ const { x, y } = computeBoundTextPosition(container, updatedTextElement);
+ boundTextUpdates.x = x;
+ boundTextUpdates.y = y;
}
mutateElement(textElement, boundTextUpdates);