Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: cancel erase elements on pointer up if eraser is not active on pointer up (#4956)

Aakansha Doshidb2859530241
diff --git a/src/components/App.tsx b/src/components/App.tsx
index fd27440a8c..cec088fd0d 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -4472,6 +4472,8 @@ class App extends React.Component<AppProps, AppState> {
}
this.eraseElements(pointerDownState);
return;
+ } else if (Object.keys(pointerDownState.elementIdsToErase).length) {
+ this.restoreReadyToEraseElements(pointerDownState);
}
if (
@@ -4613,6 +4615,32 @@ class App extends React.Component<AppProps, AppState> {
});
}
+ private restoreReadyToEraseElements = (
+ pointerDownState: PointerDownState,
+ ) => {
+ const elements = this.scene.getElements().map((ele) => {
+ if (
+ pointerDownState.elementIdsToErase[ele.id] &&
+ pointerDownState.elementIdsToErase[ele.id].erase
+ ) {
+ return newElementWith(ele, {
+ opacity: pointerDownState.elementIdsToErase[ele.id].opacity,
+ });
+ } else if (
+ isBoundToContainer(ele) &&
+ pointerDownState.elementIdsToErase[ele.containerId] &&
+ pointerDownState.elementIdsToErase[ele.containerId].erase
+ ) {
+ return newElementWith(ele, {
+ opacity: pointerDownState.elementIdsToErase[ele.containerId].opacity,
+ });
+ }
+ return ele;
+ });
+
+ this.scene.replaceAllElements(elements);
+ };
+
private eraseElements = (pointerDownState: PointerDownState) => {
const elements = this.scene.getElements().map((ele) => {
if (