Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

Encapsulate SceneHistory. A little. (#1016)

Kent Beckdc618ab12249
diff --git a/src/components/App.tsx b/src/components/App.tsx
index 40587128ea..4f6676f55e 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -2432,10 +2432,7 @@ export class App extends React.Component<any, AppState> {
this.broadcastSceneUpdate();
}
- if (history.isRecording()) {
- history.pushEntry(this.state, globalSceneState.getAllElements());
- history.skipRecording();
- }
+ history.record(this.state, globalSceneState.getAllElements());
}
}
diff --git a/src/history.ts b/src/history.ts
index a714a93635..35581c90af 100644
--- a/src/history.ts
+++ b/src/history.ts
@@ -123,17 +123,17 @@ export class SceneHistory {
return null;
}
- isRecording() {
- return this.recording;
- }
-
- skipRecording() {
- this.recording = false;
- }
-
+ // Suspicious that this is called so many places. Seems error-prone.
resumeRecording() {
this.recording = true;
}
+
+ record(state: AppState, elements: readonly ExcalidrawElement[]) {
+ if (this.recording) {
+ this.pushEntry(state, elements);
+ this.recording = false;
+ }
+ }
}
export const createHistory: () => { history: SceneHistory } = () => {