Skip to content

Virtual whiteboard for sketching hand-drawn like diagrams

fix: do not refocus element link input on unrelated updates (#9037)

David Luzarec06fbc1fcad
diff --git a/packages/excalidraw/components/hyperlink/Hyperlink.tsx b/packages/excalidraw/components/hyperlink/Hyperlink.tsx
index f94f6f392d..da187ef8da 100644
--- a/packages/excalidraw/components/hyperlink/Hyperlink.tsx
+++ b/packages/excalidraw/components/hyperlink/Hyperlink.tsx
@@ -171,15 +171,17 @@ export const Hyperlink = ({
}, [handleSubmit]);
useEffect(() => {
- let timeoutId: number | null = null;
-
if (
- inputRef &&
- inputRef.current &&
+ isEditing &&
+ inputRef?.current &&
!(device.viewport.isMobile || device.isTouchScreen)
) {
inputRef.current.select();
}
+ }, [isEditing, device.viewport.isMobile, device.isTouchScreen]);
+
+ useEffect(() => {
+ let timeoutId: number | null = null;
const handlePointerMove = (event: PointerEvent) => {
if (isEditing) {
@@ -207,15 +209,7 @@ export const Hyperlink = ({
clearTimeout(timeoutId);
}
};
- }, [
- appState,
- element,
- isEditing,
- setAppState,
- elementsMap,
- device.viewport.isMobile,
- device.isTouchScreen,
- ]);
+ }, [appState, element, isEditing, setAppState, elementsMap]);
const handleRemove = useCallback(() => {
trackEvent("hyperlink", "delete");