Skip to content

Explainer videos and product demos made by your AI agent. Free and open source: a local voice (Kokoro), word timing (Whisper) and a canvas renderer turn a script into a narrated MP4.

Try a hung engine page load once more (#29)

Vincent Schmalbach55b15b658366
diff --git a/src/browser.js b/src/browser.js
index 5ecb2df..4b71792 100644
--- a/src/browser.js
+++ b/src/browser.js
@@ -85,14 +85,26 @@ export async function launch() {
// Opens the render page and waits until the engine has loaded fonts, icons,
// images and the scenes module. Throws with the page's error if boot fails.
-export async function openEngine(browser, serverUrl, { scale = 1, transparent = false, onConsole } = {}) {
- const page = await browser.newPage({ viewport: { width: 800, height: 600 }, deviceScaleFactor: 1 });
- const errors = [];
- page.on('pageerror', (e) => errors.push(e));
- page.on('console', (m) => {
- if (onConsole) onConsole(m.type(), m.text());
- });
- await page.goto(`${serverUrl}/frame.html?scale=${scale}${transparent ? '&transparent=1' : ''}`, { waitUntil: 'load' });
+export async function openEngine(browser, serverUrl, { scale = 1, transparent = false, onConsole, timeout = 30000 } = {}) {
+ let page;
+ let errors;
+ // A busy machine sometimes leaves the first page load hanging. A fresh
+ // page almost always loads, so a load that times out is tried once more.
+ for (let attempt = 1; ; attempt++) {
+ page = await browser.newPage({ viewport: { width: 800, height: 600 }, deviceScaleFactor: 1 });
+ errors = [];
+ page.on('pageerror', (e) => errors.push(e));
+ page.on('console', (m) => {
+ if (onConsole) onConsole(m.type(), m.text());
+ });
+ try {
+ await page.goto(`${serverUrl}/frame.html?scale=${scale}${transparent ? '&transparent=1' : ''}`, { waitUntil: 'load', timeout });
+ break;
+ } catch (e) {
+ await page.close().catch(() => {});
+ if (attempt === 2 || e.name !== 'TimeoutError') throw e;
+ }
+ }
const boot = await page.evaluate(async () => {
try {
await window.explainrooReady;
diff --git a/test/browser.test.js b/test/browser.test.js
index f23a637..17116eb 100644
--- a/test/browser.test.js
+++ b/test/browser.test.js
@@ -3,6 +3,7 @@ import assert from 'node:assert/strict';
import fs from 'node:fs';
import os from 'node:os';
import path from 'node:path';
+import http from 'node:http';
import { findChrome } from '../src/browser.js';
test('finds the headless shell that Playwright installs on Windows', () => {
@@ -24,3 +25,35 @@ test('finds the headless shell that Playwright installs on Windows', () => {
fs.rmSync(base, { recursive: true, force: true });
}
});
+
+let chrome;
+try { chrome = findChrome(); } catch {}
+
+test('a page load that hangs is tried once more with a fresh page', { skip: !chrome }, async () => {
+ const { launch, openEngine } = await import('../src/browser.js');
+ let requests = 0;
+ const hung = [];
+ const server = http.createServer((req, res) => {
+ if (!req.url.startsWith('/frame.html')) return res.writeHead(404).end();
+ // The first load never answers, like a stalled page on a busy machine.
+ if (++requests === 1) return hung.push(res);
+ res.writeHead(200, { 'content-type': 'text/html' }).end('<script>window.explainrooReady = Promise.resolve();</script>');
+ });
+ await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve));
+ const browser = await launch();
+ try {
+ const page = await openEngine(browser, `http://127.0.0.1:${server.address().port}`, { timeout: 1500 });
+ assert.equal(requests, 2);
+ assert.equal(browser.contexts().flatMap((c) => c.pages()).length, 1);
+ assert.equal(await page.evaluate(() => typeof window.explainrooReady), 'object');
+ requests = 0;
+ server.removeAllListeners('request');
+ server.on('request', (req, res) => hung.push(res));
+ await assert.rejects(openEngine(browser, `http://127.0.0.1:${server.address().port}`, { timeout: 500 }), { name: 'TimeoutError' });
+ } finally {
+ await browser.close();
+ for (const res of hung) res.destroy();
+ server.closeAllConnections();
+ await new Promise((resolve) => server.close(resolve));
+ }
+});