π The fast, Pythonic way to build MCP servers and clients.
Skip skills whose SKILL.md is not valid UTF-8 during directory discovery (#5497)
Asem ahmed2df621e0ead3
diff --git a/fastmcp_slim/fastmcp/server/providers/skills/directory_provider.py b/fastmcp_slim/fastmcp/server/providers/skills/directory_provider.pyindex 4c80e1dd1..0011127f4 100644--- a/fastmcp_slim/fastmcp/server/providers/skills/directory_provider.py+++ b/fastmcp_slim/fastmcp/server/providers/skills/directory_provider.py@@ -120,7 +120,13 @@ class SkillsDirectoryProvider(AggregateProvider):)self.providers.append(provider)seen_skill_names.add(skill_name)- except (FileNotFoundError, PermissionError, OSError, PathEscapeError):+ except (+ FileNotFoundError,+ PermissionError,+ OSError,+ PathEscapeError,+ UnicodeDecodeError,+ ):logger.exception(f"Failed to load skill: {skill_dir.name}")self._discovered = Truediff --git a/tests/server/providers/test_skills_provider.py b/tests/server/providers/test_skills_provider.pyindex dadeea2bb..a2aa751ad 100644--- a/tests/server/providers/test_skills_provider.py+++ b/tests/server/providers/test_skills_provider.py@@ -678,6 +678,24 @@ Additional documentation.resources = await provider.list_resources()assert resources == []+ @pytest.mark.parametrize("reload", [False, True])+ async def test_undecodable_skill_is_skipped(self, tmp_path: Path, reload: bool):+ skills_dir = tmp_path / "skills"+ good = skills_dir / "good"+ good.mkdir(parents=True)+ (good / "SKILL.md").write_text(+ "---\ndescription: Works\n---\n# Good", encoding="utf-8"+ )+ # Notepad's "Unicode" encoding writes UTF-16, which is not valid UTF-8+ bad = skills_dir / "bad"+ bad.mkdir()+ (bad / "SKILL.md").write_text("# Bad", encoding="utf-16")++ provider = SkillsDirectoryProvider(roots=skills_dir, reload=reload)++ resources = await provider.list_resources()+ assert {r.name for r in resources} == {"good/SKILL.md", "good/_manifest"}+async def test_reload_mode(self, skills_dir: Path):provider = SkillsDirectoryProvider(roots=skills_dir, reload=True)