Skip to content

πŸš€ The fast, Pythonic way to build MCP servers and clients.

changeable allowed_client_redirect_uris (#3772)

Fatia Kusuma Dewi5587cb7c4310
diff --git a/src/fastmcp/server/auth/oauth_proxy/proxy.py b/src/fastmcp/server/auth/oauth_proxy/proxy.py
index 3210f7d6e..dbc888bd7 100644
--- a/src/fastmcp/server/auth/oauth_proxy/proxy.py
+++ b/src/fastmcp/server/auth/oauth_proxy/proxy.py
@@ -662,7 +662,7 @@ class OAuthProxy(OAuthProvider, ConsentMixin):
client = await self._client_store.get(key=client_id)
if client is not None:
- if client.allowed_redirect_uri_patterns is None:
+ if self._allowed_client_redirect_uris is not None:
client.allowed_redirect_uri_patterns = (
self._allowed_client_redirect_uris
)
diff --git a/tests/server/auth/oauth_proxy/test_client_registration.py b/tests/server/auth/oauth_proxy/test_client_registration.py
index b865b4336..49e2eceac 100644
--- a/tests/server/auth/oauth_proxy/test_client_registration.py
+++ b/tests/server/auth/oauth_proxy/test_client_registration.py
@@ -41,3 +41,29 @@ class TestOAuthProxyClientRegistration:
"""Test that unregistered clients return None."""
client = await oauth_proxy.get_client("unknown-client")
assert client is None
+
+ async def test_enforcing_allowed_redirect_uris(self, oauth_proxy):
+ """Test enforcing allowed redirect uris configuration."""
+
+ oauth_proxy._allowed_client_redirect_uris = ["http://localhost:12345/callback"]
+
+ client_info = OAuthClientInformationFull(
+ client_id="original-client",
+ client_secret="original-secret",
+ redirect_uris=[AnyUrl("http://localhost:12345/callback")],
+ )
+
+ await oauth_proxy.register_client(client_info)
+ retrieved = await oauth_proxy.get_client("original-client")
+ assert retrieved.allowed_redirect_uri_patterns == [
+ "http://localhost:12345/callback"
+ ]
+
+ oauth_proxy._allowed_client_redirect_uris = [
+ "http://localhost:12345/updated_callback"
+ ]
+
+ retrieved = await oauth_proxy.get_client("original-client")
+ assert retrieved.allowed_redirect_uri_patterns == [
+ "http://localhost:12345/updated_callback"
+ ]