π The fast, Pythonic way to build MCP servers and clients.
Keep is_error when ResponseLimitingMiddleware truncates a result (#5309)
Asem ahmed83cd06b35c6f
diff --git a/fastmcp_slim/fastmcp/server/middleware/response_limiting.py b/fastmcp_slim/fastmcp/server/middleware/response_limiting.pyindex 8dfa9ba80..075ba66e1 100644--- a/fastmcp_slim/fastmcp/server/middleware/response_limiting.py+++ b/fastmcp_slim/fastmcp/server/middleware/response_limiting.py@@ -76,6 +76,7 @@ class ResponseLimitingMiddleware(Middleware):self,text: str,meta: dict[str, Any] | None = None,+ is_error: bool = False,) -> ToolResult:"""Truncate text to fit within max_size and wrap in ToolResult."""suffix_bytes = len(self.truncation_suffix.encode("utf-8"))@@ -100,6 +101,7 @@ class ResponseLimitingMiddleware(Middleware):return ToolResult(content=[TextContent(type="text", text=truncated)],meta=meta,+ is_error=is_error,)async def on_list_tools(@@ -162,4 +164,6 @@ class ResponseLimitingMiddleware(Middleware):else serialized.decode("utf-8", errors="replace"))- return self._truncate_to_result(text, meta=result.meta)+ return self._truncate_to_result(+ text, meta=result.meta, is_error=result.is_error+ )diff --git a/tests/server/middleware/test_response_limiting.py b/tests/server/middleware/test_response_limiting.pyindex 5948b57f6..d66fe4ff6 100644--- a/tests/server/middleware/test_response_limiting.py+++ b/tests/server/middleware/test_response_limiting.py@@ -50,6 +50,19 @@ class TestResponseLimitingMiddleware:# Verify truncated result fits within limitassert len(result.content[0].text.encode("utf-8")) < 500+ async def test_truncation_preserves_is_error(self, mcp_server: FastMCP):+ """Truncating an error result keeps it an error."""+ mcp_server.add_middleware(ResponseLimitingMiddleware(max_size=500))++ @mcp_server.tool()+ def failing_tool() -> ToolResult:+ return ToolResult(content="upstream failed: " + "x" * 1000, is_error=True)++ async with Client(mcp_server) as client:+ result = await client.call_tool("failing_tool", {}, raise_on_error=False)+ assert result.is_error is True+ assert "[Response truncated due to size limit]" in result.content[0].text+async def test_tool_filtering(self, mcp_server: FastMCP):"""Test that tool filtering only applies to specified tools."""mcp_server.add_middleware(