Skip to content

πŸš€ The fast, Pythonic way to build MCP servers and clients.

Read CLI-scanned MCP config files as UTF-8 explicitly (#4690)

Jeremiah Lowind6b9daecb191
diff --git a/fastmcp_slim/fastmcp/cli/discovery.py b/fastmcp_slim/fastmcp/cli/discovery.py
index 5acd42d61..ff3c616ff 100644
--- a/fastmcp_slim/fastmcp/cli/discovery.py
+++ b/fastmcp_slim/fastmcp/cli/discovery.py
@@ -120,7 +120,7 @@ def _parse_mcp_servers(
def _parse_mcp_config(path: Path, source: str) -> list[DiscoveredServer]:
"""Parse an mcpServers-style JSON file into discovered servers."""
try:
- text = path.read_text()
+ text = path.read_text(encoding="utf-8")
except OSError as exc:
logger.debug("Could not read %s: %s", path, exc)
return []
@@ -158,7 +158,7 @@ def _scan_claude_code(start_dir: Path) -> list[DiscoveredServer]:
"""Scan ``~/.claude.json`` for global and project-scoped MCP servers."""
path = Path.home() / ".claude.json"
try:
- text = path.read_text()
+ text = path.read_text(encoding="utf-8")
except OSError:
return []
@@ -269,7 +269,7 @@ def _scan_goose() -> list[DiscoveredServer]:
path = config_dir / "config.yaml"
try:
- text = path.read_text()
+ text = path.read_text(encoding="utf-8")
except OSError:
return []
diff --git a/tests/cli/test_discovery.py b/tests/cli/test_discovery.py
index 716694353..102bbf440 100644
--- a/tests/cli/test_discovery.py
+++ b/tests/cli/test_discovery.py
@@ -148,6 +148,40 @@ class TestParseMcpConfig:
assert isinstance(servers[0].config, RemoteMCPServer)
assert servers[0].config.url == "http://localhost:8000/mcp"
+ def test_reads_as_utf8_explicitly(
+ self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+ ):
+ """Regression test for GH-4689: config files must be read with an
+ explicit UTF-8 encoding, not the platform's preferred encoding
+ (e.g. cp949 on Windows with a non-UTF-8 locale), since that's what
+ every tool that writes these files emits."""
+ original_read_text = Path.read_text
+
+ def _tracking_read_text(self: Path, *args: Any, **kwargs: Any) -> str:
+ assert kwargs.get("encoding") == "utf-8", (
+ "path.read_text() must pass encoding='utf-8' explicitly"
+ )
+ return original_read_text(self, *args, **kwargs)
+
+ monkeypatch.setattr(Path, "read_text", _tracking_read_text)
+
+ path = tmp_path / "config.json"
+ path.write_bytes(
+ json.dumps(
+ {
+ "mcpServers": {
+ "demo": {
+ "command": "echo",
+ "args": ["hello β€” world"],
+ }
+ }
+ }
+ ).encode("utf-8")
+ )
+ servers = _parse_mcp_config(path, "test")
+ assert len(servers) == 1
+ assert servers[0].name == "demo"
+
# ---------------------------------------------------------------------------
# Scanner: Claude Desktop