Skip to content

πŸš€ The fast, Pythonic way to build MCP servers and clients.

Validate workspace path is a directory in cursor install (#3426) (#3435)

Jeremiah Lowinfadb63014257
diff --git a/src/fastmcp/cli/install/cursor.py b/src/fastmcp/cli/install/cursor.py
index 0358c3261..560d17e5d 100644
--- a/src/fastmcp/cli/install/cursor.py
+++ b/src/fastmcp/cli/install/cursor.py
@@ -91,6 +91,9 @@ def install_cursor_workspace(
if not workspace_path.exists():
print(f"[red]Workspace directory does not exist: {workspace_path}[/red]")
return False
+ if not workspace_path.is_dir():
+ print(f"[red]Workspace path is not a directory: {workspace_path}[/red]")
+ return False
# Create .cursor directory in workspace
cursor_dir = workspace_path / ".cursor"
diff --git a/tests/cli/test_cursor.py b/tests/cli/test_cursor.py
index 476b678ef..3996aee34 100644
--- a/tests/cli/test_cursor.py
+++ b/tests/cli/test_cursor.py
@@ -9,6 +9,7 @@ from fastmcp.cli.install.cursor import (
cursor_command,
generate_cursor_deeplink,
install_cursor,
+ install_cursor_workspace,
open_deeplink,
)
from fastmcp.mcp_config import StdioMCPServer
@@ -356,6 +357,20 @@ class TestInstallCursor:
# Verify failure message was printed
mock_print.assert_called()
+ def test_install_cursor_workspace_path_is_file(self, tmp_path):
+ """Test that passing a file as workspace_path returns False."""
+ file_path = tmp_path / "somefile.txt"
+ file_path.write_text("hello")
+
+ result = install_cursor_workspace(
+ file=Path("/path/to/server.py"),
+ server_object=None,
+ name="test-server",
+ workspace_path=file_path,
+ )
+
+ assert result is False
+
def test_install_cursor_deduplicate_packages(self):
"""Test that duplicate packages are deduplicated."""
with patch("fastmcp.cli.install.cursor.open_deeplink") as mock_open: