Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

6.0 KB
Raw Blame
package actions_test

import (
	"context"
	"encoding/json"
	"testing"

	"github.com/getfider/fider/app/actions"
	"github.com/getfider/fider/app/models/enum"
	. "github.com/getfider/fider/app/pkg/assert"
)

func TestSignInByEmail_EmptyEmail(t *testing.T) {
	RegisterT(t)

	action := actions.SignInByEmail{Email: " "}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "email")
}

func TestSignInByEmail_InvalidEmail(t *testing.T) {
	RegisterT(t)

	action := actions.SignInByEmail{Email: "Hi :)"}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "email")
}

func TestSignInByEmail_ShouldHaveVerificationKey(t *testing.T) {
	RegisterT(t)

	action := actions.NewSignInByEmail()
	action.Email = "[email protected]"

	result := action.Validate(context.Background(), nil)
	ExpectSuccess(result)
	Expect(action.VerificationCode).IsNotEmpty()
	Expect(len(action.VerificationCode)).Equals(6)
}

func TestSignInByEmail_VerificationCodeNotOverwrittenByJSON(t *testing.T) {
	RegisterT(t)

	action := actions.NewSignInByEmail()
	originalCode := action.VerificationCode
	originalKey := action.LinkKey

	// Simulate attacker trying to overwrite internal fields via JSON binding
	payload := []byte(`{"email":"[email protected]","VerificationCode":"000000","LinkKey":"attacker-key"}`)
	err := json.Unmarshal(payload, action)
	Expect(err).IsNil()

	// VerificationCode and LinkKey must NOT be overwritten
	Expect(action.VerificationCode).Equals(originalCode)
	Expect(action.LinkKey).Equals(originalKey)
	// Email should still bind normally
	Expect(action.Email).Equals("[email protected]")
}

func TestSignInByEmailWithName_VerificationCodeNotOverwrittenByJSON(t *testing.T) {
	RegisterT(t)

	action := actions.NewSignInByEmailWithName()
	originalCode := action.VerificationCode
	originalKey := action.LinkKey

	payload := []byte(`{"email":"[email protected]","name":"Attacker","VerificationCode":"000000","LinkKey":"attacker-key"}`)
	err := json.Unmarshal(payload, action)
	Expect(err).IsNil()

	Expect(action.VerificationCode).Equals(originalCode)
	Expect(action.LinkKey).Equals(originalKey)
	Expect(action.Email).Equals("[email protected]")
	Expect(action.Name).Equals("Attacker")
}

func TestCompleteProfile_EmptyNameAndKey(t *testing.T) {
	RegisterT(t)

	action := actions.CompleteProfile{Kind: enum.EmailVerificationKindSignIn}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "name", "key")
}

func TestCompleteProfile_LongName(t *testing.T) {
	RegisterT(t)

	action := actions.CompleteProfile{
		Kind: enum.EmailVerificationKindSignIn,
		Name: "123456789012345678901234567890123456789012345678901", // 51 chars
	}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "name", "key")
}

func TestCompleteProfile_InvalidKind(t *testing.T) {
	RegisterT(t)

	for _, kind := range []enum.EmailVerificationKind{0, enum.EmailVerificationKindSignUp, enum.EmailVerificationKindChangeEmail} {
		action := actions.CompleteProfile{Kind: kind, Key: "1234567890", Name: "Hot Pie"}
		result := action.Validate(context.Background(), nil)
		ExpectFailed(result, "kind")
	}
}

func TestVerifySignInCode_EmptyEmail(t *testing.T) {
	RegisterT(t)

	action := actions.VerifySignInCode{Email: "", Code: "123456"}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "email")
}

func TestVerifySignInCode_InvalidEmail(t *testing.T) {
	RegisterT(t)

	action := actions.VerifySignInCode{Email: "invalid", Code: "123456"}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "email")
}

func TestVerifySignInCode_EmptyCode(t *testing.T) {
	RegisterT(t)

	action := actions.VerifySignInCode{Email: "[email protected]", Code: ""}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "code")
}

func TestVerifySignInCode_InvalidCodeLength(t *testing.T) {
	RegisterT(t)

	action := actions.VerifySignInCode{Email: "[email protected]", Code: "12345"}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "code")

	action2 := actions.VerifySignInCode{Email: "[email protected]", Code: "1234567"}
	result2 := action2.Validate(context.Background(), nil)
	ExpectFailed(result2, "code")
}

func TestVerifySignInCode_NonNumericCode(t *testing.T) {
	RegisterT(t)

	action := actions.VerifySignInCode{Email: "[email protected]", Code: "12345A"}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "code")
}

func TestVerifySignInCode_ValidCodeAndEmail(t *testing.T) {
	RegisterT(t)

	action := actions.VerifySignInCode{Email: "[email protected]", Code: "123456"}
	result := action.Validate(context.Background(), nil)
	ExpectSuccess(result)
}

func TestSignInByEmailWithName_EmptyEmailAndName(t *testing.T) {
	RegisterT(t)

	action := actions.SignInByEmailWithName{Email: "", Name: ""}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "email", "name")
}

func TestSignInByEmailWithName_InvalidEmail(t *testing.T) {
	RegisterT(t)

	action := actions.SignInByEmailWithName{Email: "invalid", Name: "Jon Snow"}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "email")
}

func TestSignInByEmailWithName_EmptyName(t *testing.T) {
	RegisterT(t)

	action := actions.SignInByEmailWithName{Email: "[email protected]", Name: ""}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "name")
}

func TestSignInByEmailWithName_LongName(t *testing.T) {
	RegisterT(t)

	// 101 characters
	longName := "12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901"
	action := actions.SignInByEmailWithName{Email: "[email protected]", Name: longName}
	result := action.Validate(context.Background(), nil)
	ExpectFailed(result, "name")
}

func TestSignInByEmailWithName_ValidEmailAndName(t *testing.T) {
	RegisterT(t)

	action := actions.NewSignInByEmailWithName()
	action.Email = "[email protected]"
	action.Name = "Jon Snow"

	result := action.Validate(context.Background(), nil)
	ExpectSuccess(result)
	Expect(action.VerificationCode).IsNotEmpty()
	Expect(len(action.VerificationCode)).Equals(6)
}