Open platform to collect and prioritize feedback
package handlers_test
import (
"context"
"fmt"
"net/http"
"testing"
"time"
"github.com/getfider/fider/app"
"github.com/getfider/fider/app/models/entity"
"github.com/getfider/fider/app/models/enum"
"github.com/getfider/fider/app/models/query"
"github.com/getfider/fider/app/models/cmd"
"github.com/getfider/fider/app/handlers"
. "github.com/getfider/fider/app/pkg/assert"
"github.com/getfider/fider/app/pkg/bus"
"github.com/getfider/fider/app/pkg/mock"
"github.com/getfider/fider/app/pkg/web"
)
func TestSettingsHandler(t *testing.T) {
RegisterT(t)
bus.AddHandler(func(ctx context.Context, q *query.GetCurrentUserSettings) error {
return nil
})
server := mock.NewServer()
code, _ := server.
AsUser(mock.JonSnow).
Execute(handlers.UserSettings())
Expect(code).Equals(http.StatusOK)
}
func TestUpdateUserSettingsHandler_EmptyInput(t *testing.T) {
RegisterT(t)
server := mock.NewServer()
code, _ := server.
AsUser(mock.JonSnow).
ExecutePost(handlers.UpdateUserSettings(), `{ }`)
Expect(code).Equals(http.StatusBadRequest)
}
func TestUpdateUserSettingsHandler_ValidName(t *testing.T) {
RegisterT(t)
var newName string
bus.AddHandler(func(ctx context.Context, c *cmd.UpdateCurrentUser) error {
newName = c.Name
return nil
})
bus.AddHandler(func(ctx context.Context, c *cmd.UpdateCurrentUserSettings) error {
return nil
})
bus.AddHandler(func(ctx context.Context, c *cmd.UploadImage) error {
Expect(c.Image.Upload).IsNil()
Expect(c.Image.Remove).IsFalse()
return nil
})
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
ExecutePost(handlers.UpdateUserSettings(), `{ "name": "Jon Stark", "avatarType": "gravatar" }`)
Expect(code).Equals(http.StatusOK)
Expect(newName).Equals("Jon Stark")
}
func TestUpdateUserSettingsHandler_NullAvatar(t *testing.T) {
RegisterT(t)
var updateUser *cmd.UpdateCurrentUser
bus.AddHandler(func(ctx context.Context, c *cmd.UpdateCurrentUser) error {
updateUser = c
return nil
})
bus.AddHandler(func(ctx context.Context, c *cmd.UpdateCurrentUserSettings) error {
return nil
})
bus.AddHandler(func(ctx context.Context, c *cmd.UploadImage) error {
Expect(c.Image).IsNotNil()
return nil
})
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
ExecutePost(handlers.UpdateUserSettings(), `{ "name": "Jon Stark", "avatarType": "letter", "avatar": null }`)
Expect(code).Equals(http.StatusOK)
Expect(updateUser.Avatar).IsNotNil()
Expect(updateUser.Avatar.BlobKey).Equals(mock.JonSnow.AvatarBlobKey)
}
func TestUpdateUserSettingsHandler_NullAvatar_CustomAvatarType(t *testing.T) {
RegisterT(t)
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
ExecutePost(handlers.UpdateUserSettings(), `{ "name": "Jon Stark", "avatarType": "custom", "avatar": null }`)
Expect(code).Equals(http.StatusBadRequest)
}
func TestUpdateUserSettingsHandler_NewSettings(t *testing.T) {
RegisterT(t)
var updateCmd *cmd.UpdateCurrentUser
bus.AddHandler(func(ctx context.Context, c *cmd.UpdateCurrentUser) error {
updateCmd = c
return nil
})
var updateSettingsCmd *cmd.UpdateCurrentUserSettings
bus.AddHandler(func(ctx context.Context, c *cmd.UpdateCurrentUserSettings) error {
updateSettingsCmd = c
return nil
})
bus.AddHandler(func(ctx context.Context, c *cmd.UploadImage) error {
Expect(c.Image.Upload).IsNil()
Expect(c.Image.Remove).IsFalse()
return nil
})
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
ExecutePost(handlers.UpdateUserSettings(), `{
"name": "Jon Stark",
"avatarType": "gravatar",
"settings": {
"event_notification_new_post": "1",
"event_notification_new_comment": "2",
"event_notification_change_status": "3"
}
}`)
Expect(code).Equals(http.StatusOK)
Expect(updateCmd.Name).Equals("Jon Stark")
Expect(updateCmd.AvatarType).Equals(enum.AvatarTypeGravatar)
Expect(updateSettingsCmd.Settings[enum.NotificationEventNewPost.UserSettingsKeyName]).Equals("1")
Expect(updateSettingsCmd.Settings[enum.NotificationEventNewComment.UserSettingsKeyName]).Equals("2")
Expect(updateSettingsCmd.Settings[enum.NotificationEventChangeStatus.UserSettingsKeyName]).Equals("3")
}
func TestChangeRoleHandler_Valid(t *testing.T) {
RegisterT(t)
bus.AddHandler(func(ctx context.Context, q *query.GetUserByID) error {
if q.UserID == mock.AryaStark.ID {
q.Result = mock.AryaStark
return nil
}
return app.ErrNotFound
})
var changeRole *cmd.ChangeUserRole
bus.AddHandler(func(ctx context.Context, c *cmd.ChangeUserRole) error {
changeRole = c
return nil
})
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
AddParam("role", enum.RoleAdministrator).
ExecutePost(handlers.ChangeUserRole(), fmt.Sprintf(`{ "userID": %d }`, mock.AryaStark.ID))
Expect(code).Equals(http.StatusOK)
Expect(changeRole.UserID).Equals(mock.AryaStark.ID)
Expect(changeRole.Role).Equals(enum.RoleAdministrator)
}
func TestChangeUserEmailHandler_Valid(t *testing.T) {
RegisterT(t)
bus.AddHandler(func(ctx context.Context, q *query.GetUserByEmail) error {
return app.ErrNotFound
})
var saveKeyCmd *cmd.SaveVerificationKey
bus.AddHandler(func(ctx context.Context, c *cmd.SaveVerificationKey) error {
saveKeyCmd = c
return nil
})
for _, email := range []string{
"[email protected]",
"[email protected]",
} {
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
ExecutePost(handlers.ChangeUserEmail(), fmt.Sprintf(`{ "email": "%s" }`, email))
Expect(code).Equals(http.StatusOK)
Expect(saveKeyCmd.Key).HasLen(64)
Expect(saveKeyCmd.Request.GetKind()).Equals(enum.EmailVerificationKindChangeEmail)
Expect(saveKeyCmd.Request.GetEmail()).Equals(email)
}
}
func TestChangeUserEmailHandler_Invalid(t *testing.T) {
RegisterT(t)
bus.AddHandler(func(ctx context.Context, q *query.GetUserByEmail) error {
if q.Email == mock.JonSnow.Email {
q.Result = mock.JonSnow
return nil
}
if q.Email == mock.AryaStark.Email {
q.Result = mock.AryaStark
return nil
}
return app.ErrNotFound
})
for _, email := range []string{
"",
"[email protected]",
"jon.snow",
"[email protected]",
} {
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
ExecutePost(handlers.ChangeUserEmail(), fmt.Sprintf(`{ "email": "%s" }`, email))
Expect(code).Equals(http.StatusBadRequest)
}
}
func TestVerifyChangeEmailKeyHandler_Success(t *testing.T) {
RegisterT(t)
server := mock.NewServer()
key := "th3-s3cr3t"
bus.AddHandler(func(ctx context.Context, q *query.GetVerificationByKey) error {
Expect(q.Key).Equals(key)
Expect(q.Kind).Equals(enum.EmailVerificationKindChangeEmail)
q.Result = &entity.EmailVerification{
UserID: mock.JonSnow.ID,
Key: q.Key,
Kind: q.Kind,
ExpiresAt: time.Now().Add(10 * time.Minute),
Email: "[email protected]",
}
return nil
})
bus.AddHandler(func(ctx context.Context, c *cmd.ChangeUserEmail) error {
Expect(c.UserID).Equals(mock.JonSnow.ID)
Expect(c.Email).Equals("[email protected]")
return nil
})
bus.AddHandler(func(ctx context.Context, c *cmd.SetKeyAsVerified) error {
Expect(c.Key).Equals(key)
return nil
})
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.JonSnow).
WithURL("/change-email/verify?k=" + key).
Execute(handlers.VerifyChangeEmailKey())
Expect(code).Equals(http.StatusTemporaryRedirect)
ExpectHandler(&query.GetVerificationByKey{}).CalledOnce()
ExpectHandler(&cmd.ChangeUserEmail{}).CalledOnce()
ExpectHandler(&cmd.SetKeyAsVerified{}).CalledOnce()
}
func TestVerifyChangeEmailKeyHandler_DifferentUser(t *testing.T) {
RegisterT(t)
key := "th3-s3cr3t"
bus.AddHandler(func(ctx context.Context, q *query.GetVerificationByKey) error {
if q.Key == key && q.Kind == enum.EmailVerificationKindChangeEmail {
q.Result = &entity.EmailVerification{
Key: q.Key,
Kind: q.Kind,
ExpiresAt: time.Now().Add(10 * time.Minute),
Email: "[email protected]",
}
return nil
}
return app.ErrNotFound
})
server := mock.NewServer()
code, _ := server.
OnTenant(mock.DemoTenant).
AsUser(mock.AryaStark).
WithURL("/change-email/verify?k=" + key).
Execute(handlers.VerifyChangeEmailKey())
Expect(code).Equals(http.StatusTemporaryRedirect)
}
func TestDeleteUserHandler(t *testing.T) {
RegisterT(t)
var deleteCmd *cmd.DeleteCurrentUser
bus.AddHandler(func(ctx context.Context, c *cmd.DeleteCurrentUser) error {
deleteCmd = c
return nil
})
server := mock.NewServer()
code, response := server.
AsUser(mock.JonSnow).
Execute(handlers.DeleteUser())
Expect(code).Equals(http.StatusOK)
Expect(response.Header().Get("Set-Cookie")).ContainsSubstring(web.CookieAuthName + "=; Path=/; Expires=")
Expect(response.Header().Get("Set-Cookie")).ContainsSubstring("Max-Age=0; HttpOnly")
Expect(deleteCmd).IsNotNil()
}