Open platform to collect and prioritize feedback
fix error on cname lookup
goenning0b6dae9bd80c
diff --git a/app/pkg/web/ssl.go b/app/pkg/web/ssl.goindex f1136e353..a52437480 100644--- a/app/pkg/web/ssl.go+++ b/app/pkg/web/ssl.go@@ -72,7 +72,7 @@ func isValidHostName(ctx context.Context, host string) error {cname, err := net.DefaultResolver.LookupCNAME(ctx, host)if err != nil {- return errors.Wrap(err, "failed to lookup CNAME")+ return errors.Wrap(errInvalidHostName, "failed to lookup CNAME")}if cname == "" {@@ -86,7 +86,7 @@ func isValidHostName(ctx context.Context, host string) error {return nil}-//CertificateManager is used to manage SSL certificates+// CertificateManager is used to manage SSL certificatestype CertificateManager struct {ctx context.Contextcert tls.Certificate@@ -94,7 +94,7 @@ type CertificateManager struct {autotls autocert.Manager}-//NewCertificateManager creates a new CertificateManager+// NewCertificateManager creates a new CertificateManagerfunc NewCertificateManager(ctx context.Context, certFile, keyFile string) (*CertificateManager, error) {manager := &CertificateManager{ctx: ctx,@@ -122,9 +122,9 @@ func NewCertificateManager(ctx context.Context, certFile, keyFile string) (*Certreturn manager, nil}-//GetCertificate decides which certificate to use-//It first tries to use loaded certificate for incoming request if it's compatible-//Otherwise fallsback to a automatically generated certificate by Let's Encrypt+// GetCertificate decides which certificate to use+// It first tries to use loaded certificate for incoming request if it's compatible+// Otherwise fallsback to a automatically generated certificate by Let's Encryptfunc (m *CertificateManager) GetCertificate(hello *tls.ClientHelloInfo) (*tls.Certificate, error) {if m.leaf != nil {serverName, err := idna.Lookup.ToASCII(hello.ServerName)@@ -168,7 +168,7 @@ func (m *CertificateManager) GetCertificate(hello *tls.ClientHelloInfo) (*tls.Cereturn cert, err}-//StartHTTPServer creates a new HTTP server on port 80 that is used for the ACME HTTP Challenge+// StartHTTPServer creates a new HTTP server on port 80 that is used for the ACME HTTP Challengefunc (m *CertificateManager) StartHTTPServer() {err := http.ListenAndServe(":80", m.autotls.HTTPHandler(nil))if err != nil {