Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

refactor(email): avoid shadowing err in implicit TLS branch

Matt Roberts0f63b311064d
diff --git a/app/services/email/smtp/smtp.go b/app/services/email/smtp/smtp.go
index 962524c9c..bc2c990b2 100644
--- a/app/services/email/smtp/smtp.go
+++ b/app/services/email/smtp/smtp.go
@@ -117,7 +117,8 @@ var Send = func(localName, serverAddress string, enableStartTLS, enableImplicitT
if enableImplicitTLS {
// Implicit TLS (SMTPS): wrap connection in TLS before any SMTP command.
// Typically used on port 465.
- conn, err := tls.Dial("tcp", serverAddress, &tls.Config{ServerName: host})
+ var conn *tls.Conn
+ conn, err = tls.Dial("tcp", serverAddress, &tls.Config{ServerName: host})
if err != nil {
return err
}