Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

feature: add API to return list of voters (#654)

Guilherme Oenning179960fc981b
diff --git a/app/cmd/routes.go b/app/cmd/routes.go
index f3b9290c7..843145e89 100644
--- a/app/cmd/routes.go
+++ b/app/cmd/routes.go
@@ -175,6 +175,7 @@ func routes(r *web.Engine) *web.Engine {
api.Get("/api/v1/users", apiv1.ListUsers())
api.Put("/api/v1/posts/:number", apiv1.UpdatePost())
+ api.Get("/api/v1/posts/:number/voters", apiv1.ListVoters())
api.Post("/api/v1/invitations/send", apiv1.SendInvites())
api.Post("/api/v1/invitations/sample", apiv1.SendSampleInvite())
api.Put("/api/v1/posts/:number/status", apiv1.SetResponse())
diff --git a/app/handlers/apiv1/post.go b/app/handlers/apiv1/post.go
index 6138fd474..fb6a9ac30 100644
--- a/app/handlers/apiv1/post.go
+++ b/app/handlers/apiv1/post.go
@@ -264,6 +264,28 @@ func Unsubscribe() web.HandlerFunc {
}
}
+// ListVoters returns a list of all users that voted on given post
+func ListVoters() web.HandlerFunc {
+ return func(c web.Context) error {
+ number, err := c.ParamAsInt("number")
+ if err != nil {
+ return c.NotFound()
+ }
+
+ post, err := c.Services().Posts.GetByNumber(number)
+ if err != nil {
+ return c.Failure(err)
+ }
+
+ users, err := c.Services().Posts.ListVoters(post)
+ if err != nil {
+ return c.Failure(err)
+ }
+
+ return c.Ok(users)
+ }
+}
+
func addOrRemove(c web.Context, addOrRemove func(post *models.Post, user *models.User) error) error {
number, err := c.ParamAsInt("number")
if err != nil {
diff --git a/app/storage/inmemory/post.go b/app/storage/inmemory/post.go
index 6016b11db..4ffb7b80c 100644
--- a/app/storage/inmemory/post.go
+++ b/app/storage/inmemory/post.go
@@ -234,6 +234,11 @@ func (s *PostStorage) VotedBy() ([]int, error) {
return s.postsVotedBy[s.user.ID], nil
}
+// ListVoters returns a list of all users that voted on given post
+func (s *PostStorage) ListVoters(post *models.Post) ([]*models.User, error) {
+ return make([]*models.User, 0), nil
+}
+
// AddSubscriber adds user to the post list of subscribers
func (s *PostStorage) AddSubscriber(post *models.Post, user *models.User) error {
s.postSubscribers[post.ID] = append(s.postSubscribers[post.ID], user)
diff --git a/app/storage/postgres/post.go b/app/storage/postgres/post.go
index 9656589db..7addb35d5 100644
--- a/app/storage/postgres/post.go
+++ b/app/storage/postgres/post.go
@@ -711,3 +711,26 @@ func (s *PostStorage) VotedBy() ([]int, error) {
}
return posts, nil
}
+
+// ListVoters returns a list of all users that voted on given post
+func (s *PostStorage) ListVoters(post *models.Post) ([]*models.User, error) {
+ var users []*dbUser
+ err := s.trx.Select(&users, `
+ SELECT u.id, u.name, u.email, u.tenant_id, u.role, u.status
+ FROM post_votes pv
+ INNER JOIN users u
+ ON u.id = pv.user_id
+ AND u.tenant_id = pv.tenant_id
+ WHERE pv.post_id = $1
+ AND pv.tenant_id = $2
+ ORDER BY pv.created_at`, post.ID, s.tenant.ID)
+ if err != nil {
+ return nil, errors.Wrap(err, "failed to get voters of post")
+ }
+
+ var result = make([]*models.User, len(users))
+ for i, user := range users {
+ result[i] = user.toModel()
+ }
+ return result, nil
+}
diff --git a/app/storage/postgres/post_test.go b/app/storage/postgres/post_test.go
index 7e4af52a9..c6c65cb38 100644
--- a/app/storage/postgres/post_test.go
+++ b/app/storage/postgres/post_test.go
@@ -526,3 +526,20 @@ func TestPostStorage_IsReferenced(t *testing.T) {
Expect(referenced).IsTrue()
Expect(err).IsNil()
}
+
+func TestPostStorage_ListVotersOfPost(t *testing.T) {
+ SetupDatabaseTest(t)
+ defer TeardownDatabaseTest()
+
+ posts.SetCurrentTenant(demoTenant)
+ posts.SetCurrentUser(jonSnow)
+ post1, _ := posts.Add("My new post", "with this description")
+ posts.AddVote(post1, jonSnow)
+ posts.AddVote(post1, aryaStark)
+
+ users, err := posts.ListVoters(post1)
+ Expect(err).IsNil()
+ Expect(users).HasLen(2)
+ Expect(users[0].Name).Equals("Jon Snow")
+ Expect(users[1].Name).Equals("Arya Stark")
+}
diff --git a/app/storage/storage.go b/app/storage/storage.go
index 4dca27533..72bc1b53c 100644
--- a/app/storage/storage.go
+++ b/app/storage/storage.go
@@ -37,6 +37,7 @@ type Post interface {
MarkAsDuplicate(post *models.Post, original *models.Post) error
IsReferenced(post *models.Post) (bool, error)
VotedBy() ([]int, error)
+ ListVoters(post *models.Post) ([]*models.User, error)
}
// User is used for user operations