Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

Remove web notifications when a post is deleted

Matt Roberts2970f073da52
diff --git a/app/services/sqlstore/postgres/post.go b/app/services/sqlstore/postgres/post.go
index e88588860..af9ca1aa8 100644
--- a/app/services/sqlstore/postgres/post.go
+++ b/app/services/sqlstore/postgres/post.go
@@ -157,6 +157,13 @@ func setPostResponse(ctx context.Context, c *cmd.SetPostResponse) error {
return errors.Wrap(err, "failed to update post's response")
}
+ if c.Status == enum.PostDeleted {
+ _, err = trx.Execute("DELETE FROM notifications WHERE tenant_id = $1 AND post_id = $2", tenant.ID, c.Post.ID)
+ if err != nil {
+ return errors.Wrap(err, "failed to delete notifications of deleted post")
+ }
+ }
+
c.Post.Status = c.Status
c.Post.Response = &entity.PostResponse{
Text: c.Text,
diff --git a/app/services/sqlstore/postgres/post_test.go b/app/services/sqlstore/postgres/post_test.go
index 815a87d76..75246e4d3 100644
--- a/app/services/sqlstore/postgres/post_test.go
+++ b/app/services/sqlstore/postgres/post_test.go
@@ -672,8 +672,14 @@ func TestPostStorage_SetResponse_AsDeleted(t *testing.T) {
err := bus.Dispatch(jonSnowCtx, newPost)
Expect(err).IsNil()
+ bus.MustDispatch(jonSnowCtx, &cmd.AddNewNotification{User: aryaStark, Title: "New comment", Link: "/posts/1", PostID: newPost.Result.ID})
+
bus.MustDispatch(jonSnowCtx, &cmd.SetPostResponse{Post: newPost.Result, Text: "Spam!", Status: enum.PostDeleted})
+ activeNotifications := &query.GetActiveNotifications{}
+ bus.MustDispatch(aryaStarkCtx, activeNotifications)
+ Expect(activeNotifications.Result).HasLen(0)
+
postByID := &query.GetPostByID{PostID: newPost.Result.ID}
err = bus.Dispatch(aryaStarkCtx, postByID)
Expect(errors.Cause(err)).Equals(app.ErrNotFound)