Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

fix: TAB bug on pages with modal (#325)

Guilherme Oenning33bb4b490476
diff --git a/public/components/common/Modal.tsx b/public/components/common/Modal.tsx
index b1622a5fb..ee2a22561 100644
--- a/public/components/common/Modal.tsx
+++ b/public/components/common/Modal.tsx
@@ -33,12 +33,12 @@ class ModalWindow extends React.Component<ModalWindowProps, ModalWindowState> {
center: true
};
- public componentDidMount() {
- document.addEventListener("keydown", this.keyDown, false);
- }
-
- public componentWillUnmount() {
- document.removeEventListener("keydown", this.keyDown, false);
+ public componentWillUpdate(nextProps: ModalWindowProps, nextState: ModalWindowState) {
+ if (nextState.isOpen) {
+ document.addEventListener("keydown", this.keyDown, false);
+ } else {
+ document.removeEventListener("keydown", this.keyDown, false);
+ }
}
public componentWillReceiveProps(nextProps: ModalWindowProps) {