Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

refactoring: typos, better API response (#543)

Guilherme Oenning4b38bdab5bf5
diff --git a/app/handlers/apiv1/post.go b/app/handlers/apiv1/post.go
index 1d945b971..81e85b530 100644
--- a/app/handlers/apiv1/post.go
+++ b/app/handlers/apiv1/post.go
@@ -43,7 +43,12 @@ func CreatePost() web.HandlerFunc {
c.Enqueue(tasks.NotifyAboutNewPost(post))
- return c.Ok(post)
+ return c.Ok(web.Map{
+ "id": post.ID,
+ "number": post.Number,
+ "title": post.Title,
+ "slug": post.Slug,
+ })
}
}
@@ -145,14 +150,16 @@ func PostComment() web.HandlerFunc {
return c.Failure(err)
}
- _, err = c.Services().Posts.AddComment(post, input.Model.Content)
+ id, err := c.Services().Posts.AddComment(post, input.Model.Content)
if err != nil {
return c.Failure(err)
}
c.Enqueue(tasks.NotifyAboutNewComment(post, input.Model))
- return c.Ok(web.Map{})
+ return c.Ok(web.Map{
+ "id": id,
+ })
}
}
diff --git a/app/models/feedback.go b/app/models/feedback.go
index 51f13f379..5731b8e36 100644
--- a/app/models/feedback.go
+++ b/app/models/feedback.go
@@ -89,8 +89,8 @@ type Comment struct {
Content string `json:"content"`
CreatedAt time.Time `json:"createdAt"`
User *User `json:"user"`
- EditedAt *time.Time `json:"editedAt"`
- EditedBy *User `json:"editedBy"`
+ EditedAt *time.Time `json:"editedAt,omitempty"`
+ EditedBy *User `json:"editedBy,omitempty"`
}
//Tag represents a simple tag
diff --git a/public/pages/Administration/components/TagListItem.tsx b/public/pages/Administration/components/TagListItem.tsx
index a40a3ef3a..9e59c73df 100644
--- a/public/pages/Administration/components/TagListItem.tsx
+++ b/public/pages/Administration/components/TagListItem.tsx
@@ -8,7 +8,7 @@ import { actions, Failure, Fider } from "@fider/services";
interface TagListItemProps {
tag: Tag;
- onTagEditted: (tag: Tag) => void;
+ onTagEdited: (tag: Tag) => void;
onTagDeleted: (tag: Tag) => void;
}
@@ -68,7 +68,7 @@ export class TagListItem extends React.Component<TagListItemProps, TagListItemSt
tag
});
- this.props.onTagEditted(tag);
+ this.props.onTagEdited(tag);
} else {
return result.error;
}
diff --git a/public/pages/Administration/pages/ManageTags.page.tsx b/public/pages/Administration/pages/ManageTags.page.tsx
index 81c794293..f07d81e40 100644
--- a/public/pages/Administration/pages/ManageTags.page.tsx
+++ b/public/pages/Administration/pages/ManageTags.page.tsx
@@ -73,7 +73,7 @@ export class ManageTagsPage extends AdminBasePage<ManageTagsPageProps, ManageTag
});
};
- private handleTagEditted = (tag: Tag) => {
+ private handleTagEdited = (tag: Tag) => {
this.setState({
allTags: this.state.allTags.sort(tagSorter)
});
@@ -81,9 +81,7 @@ export class ManageTagsPage extends AdminBasePage<ManageTagsPageProps, ManageTag
private getTagList(filter: (tag: Tag) => boolean) {
return this.state.allTags.filter(filter).map(t => {
- return (
- <TagListItem key={t.id} tag={t} onTagDeleted={this.handleTagDeleted} onTagEditted={this.handleTagEditted} />
- );
+ return <TagListItem key={t.id} tag={t} onTagDeleted={this.handleTagDeleted} onTagEdited={this.handleTagEdited} />;
});
}
diff --git a/public/pages/ShowPost/components/ShowComment.tsx b/public/pages/ShowPost/components/ShowComment.tsx
index 542feaa4d..1a4b1793f 100644
--- a/public/pages/ShowPost/components/ShowComment.tsx
+++ b/public/pages/ShowPost/components/ShowComment.tsx
@@ -66,7 +66,7 @@ export class ShowComment extends React.Component<ShowCommentProps, ShowCommentSt
public render() {
const c = this.state.comment;
- const edittedMetadata = !!c.editedAt &&
+ const editedMetadata = !!c.editedAt &&
!!c.editedBy && (
<div className="c-comment-metadata">
·{" "}
@@ -82,7 +82,7 @@ export class ShowComment extends React.Component<ShowCommentProps, ShowCommentSt
<div className="c-comment-metadata">
· <Moment date={c.createdAt} />
</div>
- {edittedMetadata}
+ {editedMetadata}
{!this.state.isEditting &&
this.canEditComment(c) && (
<div className="c-comment-metadata">
diff --git a/public/services/actions/post.ts b/public/services/actions/post.ts
index 8df1ebbe7..a9e5d8e9c 100644
--- a/public/services/actions/post.ts
+++ b/public/services/actions/post.ts
@@ -73,8 +73,15 @@ export const respond = async (postNumber: number, input: SetResponseInput): Prom
.then(http.event("post", "respond"));
};
-export const createPost = async (title: string, description: string): Promise<Result<Post>> => {
- return http.post<Post>(`/api/v1/posts`, { title, description }).then(http.event("post", "create"));
+interface CreatePostResponse {
+ id: number;
+ number: number;
+ title: string;
+ slug: string;
+}
+
+export const createPost = async (title: string, description: string): Promise<Result<CreatePostResponse>> => {
+ return http.post<CreatePostResponse>(`/api/v1/posts`, { title, description }).then(http.event("post", "create"));
};
export const updatePost = async (postNumber: number, title: string, description: string): Promise<Result> => {