Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

enhancement: add some context to worker error (#302)

Guilherme Oenning55a92cfa7472
diff --git a/app/pkg/worker/worker.go b/app/pkg/worker/worker.go
index 5271271d0..892074fb6 100644
--- a/app/pkg/worker/worker.go
+++ b/app/pkg/worker/worker.go
@@ -1,6 +1,8 @@
package worker
import (
+ "fmt"
+
"github.com/getfider/fider/app/pkg/log"
)
@@ -57,7 +59,7 @@ func (w *BackgroundWorker) Run(id string) {
}
if err := w.middleware(task.Job)(c); err != nil {
- w.logger.Error(err)
+ w.logError(task, c, err)
}
}
@@ -82,3 +84,18 @@ func (w *BackgroundWorker) Length() int {
func (w *BackgroundWorker) Use(middleware MiddlewareFunc) {
w.middleware = middleware
}
+
+func (w *BackgroundWorker) logError(task Task, ctx *Context, err error) {
+ tenant := "undefined"
+ if ctx.Tenant() != nil {
+ tenant = fmt.Sprintf("%s (%d)", ctx.Tenant().Name, ctx.Tenant().ID)
+ }
+
+ user := "not signed in"
+ if ctx.User() != nil {
+ user = fmt.Sprintf("%s (%d)", ctx.User().Name, ctx.User().ID)
+ }
+
+ message := fmt.Sprintf("Task: %s\nTenant: %s\nUser: %s\n%s", task.Name, tenant, user, err.Error())
+ w.logger.Errorf(log.Red(message))
+}