Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

Default LOG_SQL to false

sap11106b85dd3ba565
diff --git a/.example.env b/.example.env
index 5214e3965..cdeb78969 100644
--- a/.example.env
+++ b/.example.env
@@ -9,7 +9,7 @@ JWT_SECRET=hsjl]W;&ZcHxT&FK;s%bgIQF:#ch=~#Al4:5]N;7V<qPZ3e9lT4'%;go;LIkc%k
LOG_LEVEL=DEBUG
LOG_CONSOLE=true
-LOG_SQL=true
+LOG_SQL=false
LOG_FILE=false
LOG_FILE_OUTPUT=logs/output.log
diff --git a/app/pkg/env/env.go b/app/pkg/env/env.go
index 39b113ed4..143f4cee6 100644
--- a/app/pkg/env/env.go
+++ b/app/pkg/env/env.go
@@ -85,7 +85,7 @@ type config struct {
Level string `env:"LOG_LEVEL,default=INFO"`
Structured bool `env:"LOG_STRUCTURED,default=false"`
Console bool `env:"LOG_CONSOLE,default=true"`
- Sql bool `env:"LOG_SQL,default=true"`
+ Sql bool `env:"LOG_SQL,default=false"`
File bool `env:"LOG_FILE,default=false"`
OutputFile string `env:"LOG_FILE_OUTPUT,default=logs/output.log"`
}
diff --git a/app/pkg/env/env_test.go b/app/pkg/env/env_test.go
index a2f3ac91e..adf64d8c4 100644
--- a/app/pkg/env/env_test.go
+++ b/app/pkg/env/env_test.go
@@ -66,3 +66,15 @@ func TestSubdomain(t *testing.T) {
Expect(env.Subdomain("test.fidercdn.com")).Equals("")
Expect(env.Subdomain("helloworld.com")).Equals("")
}
+
+func TestLogSqlDefaultsToFalse(t *testing.T) {
+ RegisterT(t)
+
+ // Cleanups run in reverse order, so the config is reloaded only after
+ // t.Setenv has restored the original value.
+ t.Cleanup(env.Reload)
+ t.Setenv("LOG_SQL", "")
+
+ env.Reload()
+ Expect(env.Config.Log.Sql).IsFalse()
+}