Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

Changed notification to use <a> link (#1274)

Matt Roberts7d6ce66aedca
diff --git a/public/components/NotificationIndicator.tsx b/public/components/NotificationIndicator.tsx
index 1c3a1f3cd..c54776766 100644
--- a/public/components/NotificationIndicator.tsx
+++ b/public/components/NotificationIndicator.tsx
@@ -8,17 +8,13 @@ import { actions, Fider } from "@fider/services"
import { Avatar, Icon, Markdown, Moment } from "./common"
import { Dropdown } from "./common/Dropdown"
import { Notification } from "@fider/models"
-import { HStack, VStack } from "./layout"
+import { VStack } from "./layout"
import { Trans } from "@lingui/react/macro"
export const NotificationItem = ({ notification }: { notification: Notification }) => {
- const openNotification = () => {
- window.location.href = `/notifications/${notification.id}`
- }
-
return (
- <HStack spacing={4} className="px-3 pr-5 clickable hover py-4" onClick={openNotification}>
+ <a href={`/notifications/${notification.id}`} className="px-3 pr-5 hover py-4 flex flex-x flex--spacing-4 flex-items-center">
<Avatar user={{ name: notification.authorName, avatarURL: notification.avatarURL }} />
<div>
<Markdown className="c-notification-indicator-text" text={notification.title} style="full" />
@@ -26,7 +22,7 @@ export const NotificationItem = ({ notification }: { notification: Notification
<Moment locale={Fider.currentLocale} date={notification.createdAt} />
</span>
</div>
- </HStack>
+ </a>
)
}