Open platform to collect and prioritize feedback
refactor e2e (#251)
Guilherme Oenning7e48a5112a9c
diff --git a/tests/e2e-multi.ts b/tests/e2e-multi.tsindex 6cf7a1af6..9d4e17798 100644--- a/tests/e2e-multi.ts+++ b/tests/e2e-multi.ts@@ -1,3 +1,3 @@process.env.HOST_MODE = 'multi';-require('./testcases/SignUpByEmail');-require('./testcases/SubmitIdeas');+require('./testcases/email-signup');+require('./testcases/entry');diff --git a/tests/e2e-single.ts b/tests/e2e-single.tsindex 8ed0811ac..bee5bc4bf 100644--- a/tests/e2e-single.ts+++ b/tests/e2e-single.ts@@ -1,2 +1,2 @@process.env.HOST_MODE = 'single';-require('./testcases/SubmitIdeas');+require('./testcases/entry');diff --git a/tests/lib/browser.ts b/tests/lib/browser.tsindex c0f9f0d01..194562a8f 100644--- a/tests/lib/browser.ts+++ b/tests/lib/browser.ts@@ -6,7 +6,6 @@ export class Browser {private driver: ThenableWebDriver;public constructor(private browserName: string) {this.driver = new Builder().forBrowser('chrome').build();- this.driver.manage().timeouts().implicitlyWait(5 * 1000);}public async navigate(url: string): Promise<void> {diff --git a/tests/lib/components.ts b/tests/lib/components.tsindex dfbcb04c6..8c03683cf 100644--- a/tests/lib/components.ts+++ b/tests/lib/components.ts@@ -15,6 +15,10 @@ export class WebComponent {}}+ public async getAttribute(attrName: string): Promise<string> {+ return await this.element.getAttribute(attrName);+ }+public async isDisplayed() {try {return await this.element.isDisplayed();diff --git a/tests/lib/ensure.ts b/tests/lib/ensure.tsindex b8f7237be..9e7346321 100644--- a/tests/lib/ensure.ts+++ b/tests/lib/ensure.ts@@ -30,6 +30,16 @@ class WebComponentEnsurer {});}+ public async attributeIs(attrName: string, expected: string) {+ await this.retry(async () => {+ const value = await this.component.getAttribute(attrName);++ if (value.trim() !== expected.trim()) {+ throw new Error(`Element ${this.component.selector} attribute '${attrName}' is '${value}'. Expected value is '${expected}'`);+ }+ });+ }+public async isVisible() {await this.retry(async () => {if (!await this.component.isDisplayed()) {diff --git a/tests/lib/mailgun/index.ts b/tests/lib/mailgun/index.tsindex 93ab7ef1a..60c3b6075 100644--- a/tests/lib/mailgun/index.ts+++ b/tests/lib/mailgun/index.ts@@ -34,11 +34,11 @@ export const mailgun = {if (events.items.length > 0 && events.items[0].message.headers.to === to) {messageUrl = events.items[0].storage.url;} else {- await delay(5000);+ await delay(500);}- } while (!messageUrl && count < 6);+ } while (!messageUrl && count < 60);- if (count === 6) {+ if (count === 60) {throw new Error(`Message not found for ${to}.`);}diff --git a/tests/pages/AdminSettingsPage.ts b/tests/pages/AdminSettingsPage.tsnew file mode 100644index 000000000..b10f3ef20--- /dev/null+++ b/tests/pages/AdminSettingsPage.ts@@ -0,0 +1,28 @@+import { WebComponent, Browser, Page, findBy, findMultipleBy, Button, TextInput, elementIsVisible, elementIsNotVisible, pageHasLoaded } from '../lib';+import { tenant } from '../context';++export class AdminSettingsPage extends Page {+ constructor(browser: Browser) {+ super(browser);+ }++ public getUrl(): string {+ return `http://${tenant}.dev.fider.io:3000/admin`;+ }++ @findBy('#title')+ public TitleInput: TextInput;++ @findBy('#welcome-message')+ public WelcomeMessageInput: TextInput;++ @findBy('#invitation')+ public InvitationInput: TextInput;++ @findBy('button.positive')+ public ConfirmButton: Button;++ public loadCondition() {+ return elementIsVisible(() => this.TitleInput);+ }+}diff --git a/tests/pages/FacebookSignInPage.ts b/tests/pages/FacebookSignInPage.tsindex 4de3e9ba5..fd5c4daa3 100644--- a/tests/pages/FacebookSignInPage.ts+++ b/tests/pages/FacebookSignInPage.ts@@ -1,4 +1,4 @@-import { TextInput, Button, Browser, WebComponent, Page, findBy, elementIsVisible, elementIsPresent, pageHasLoaded, delay } from '../lib';+import { TextInput, Button, Browser, WebComponent, Page, findBy, elementIsPresent, pageHasLoaded } from '../lib';import { HomePage, SignUpPage } from './';import config from '../config';diff --git a/tests/pages/GoogleSignInPage.ts b/tests/pages/GoogleSignInPage.tsindex f52831961..f23b7df15 100644--- a/tests/pages/GoogleSignInPage.ts+++ b/tests/pages/GoogleSignInPage.ts@@ -1,4 +1,4 @@-import { TextInput, Button, Browser, WebComponent, Page, findBy, elementIsVisible, elementIsPresent, pageHasLoaded, delay } from '../lib';+import { TextInput, Button, Browser, WebComponent, Page, findBy, elementIsVisible, elementIsPresent, pageHasLoaded } from '../lib';import { HomePage, SignUpPage } from './';import config from '../config';diff --git a/tests/pages/HomePage.ts b/tests/pages/HomePage.tsindex b2d007ca9..9d3b5cc1f 100644--- a/tests/pages/HomePage.ts+++ b/tests/pages/HomePage.ts@@ -14,6 +14,12 @@ export class HomePage extends Page {return `http://${tenant}.dev.fider.io:3000/`;}+ @findBy('.menu a.header')+ public MenuTitle: WebComponent;++ @findBy('.page .welcome-message')+ public WelcomeMessage: WebComponent;+@findBy('#new-idea-input')public IdeaTitle: TextInput;diff --git a/tests/pages/SignUpPage.ts b/tests/pages/SignUpPage.tsindex 6bcfd8dd7..1db63a041 100644--- a/tests/pages/SignUpPage.ts+++ b/tests/pages/SignUpPage.ts@@ -1,4 +1,4 @@-import { WebComponent, Browser, Page, Button, TextInput, findBy, elementIsVisible, pageHasLoaded, delay } from '../lib';+import { WebComponent, Browser, Page, Button, TextInput, findBy, elementIsVisible, pageHasLoaded } from '../lib';import { GoogleSignInPage, FacebookSignInPage, HomePage } from './';export class SignUpPage extends Page {diff --git a/tests/pages/index.ts b/tests/pages/index.tsindex a5e96b11f..f3b9d9e91 100644--- a/tests/pages/index.ts+++ b/tests/pages/index.ts@@ -1,6 +1,7 @@import { GoogleSignInPage } from './GoogleSignInPage';import { FacebookSignInPage } from './FacebookSignInPage';import { HomePage } from './HomePage';+import { AdminSettingsPage } from './AdminSettingsPage';import { ShowIdeaPage } from './ShowIdeaPage';import { SignUpPage } from './SignUpPage';import { Browser } from '../lib';@@ -11,12 +12,14 @@ export {SignUpPage,ShowIdeaPage,FacebookSignInPage,+ AdminSettingsPage,};export class AllPages {public google: GoogleSignInPage;public facebook: FacebookSignInPage;public home: HomePage;+ public adminSettings: AdminSettingsPage;public signup: SignUpPage;public showIdea: ShowIdeaPage;@@ -26,6 +29,7 @@ export class AllPages {this.home = new HomePage(browser);this.signup = new SignUpPage(browser);this.showIdea = new ShowIdeaPage(browser);+ this.adminSettings = new AdminSettingsPage(browser);}public async goTo(url: string): Promise<void> {diff --git a/tests/testcases/SubmitIdeas.ts b/tests/testcases/SubmitIdeas.tsdeleted file mode 100644index e7b313464..000000000--- a/tests/testcases/SubmitIdeas.ts+++ /dev/null@@ -1,180 +0,0 @@-import { ensure, elementIsVisible, elementIsNotVisible, mailgun, delay } from '../lib';-import { pages, tenant, browser } from '../context';-import { createTenant } from './setup';-import {- equal as assertEqual-} from 'assert';--describe('Submit ideas', () => {-- before(async () => {- await createTenant();- });-- after(async () => {- await pages.dispose();- });-- it('User is authenticated after sign up', async () => {- // Action- await pages.home.navigate();- await pages.home.UserMenu.click();-- // Assert- await ensure(pages.home.UserName).textIs('JON SNOW');- });-- it('User doesn\'t lose what they typed', async () => {- // Action- await pages.home.navigate();- await pages.home.IdeaTitle.type('My Great Idea');- await pages.home.IdeaDescription.type('With an awesome description');-- await pages.home.IdeaTitle.clear();- await pages.home.IdeaTitle.type('My Great Idea has a new title');-- // Assert- await ensure(pages.home.IdeaTitle).textIs('My Great Idea has a new title');- await ensure(pages.home.IdeaDescription).textIs('With an awesome description');-- // Action- await pages.home.navigate();-- // Assert- await ensure(pages.home.IdeaTitle).textIs('My Great Idea has a new title');- await ensure(pages.home.IdeaDescription).textIs('With an awesome description');-- // Action- await pages.home.IdeaDescription.clear();- await pages.home.IdeaTitle.clear();- await pages.home.navigate();-- // Assert- await ensure(pages.home.IdeaTitle).textIs('');- await browser.wait(elementIsNotVisible(() => pages.home.IdeaDescription));- });-- it('Unauthenticated users cannot submit ideas', async () => {- // Action- await pages.home.navigate();- await pages.home.signOut();- await pages.home.IdeaTitle.click();-- // Assert- await browser.wait(elementIsVisible(() => pages.home.SignInModal));- });-- it('Authenticated user can submit ideas', async () => {- // Action- await pages.home.navigate();- await pages.home.signInWithFacebook();- await pages.facebook.signInAsJonSnow();- await pages.home.UserMenu.click();-- // Assert- await ensure(pages.home.UserName).textIs('JON SNOW');-- // Action- await pages.home.submitNewIdea('Add support to TypeScript', 'Because the language and community is awesome! :)');-- // Assert- await ensure(pages.showIdea.Title).textIs('Add support to TypeScript');- await ensure(pages.showIdea.Description).textIs('Because the language and community is awesome! :)');- await ensure(pages.showIdea.SupportCounter).textIs('1');- });-- it('Admin can change status', async () => {- // Action & Assert- await pages.home.navigate();- await pages.home.IdeaList.navigateAndWait(0, pages.showIdea.loadCondition());- await pages.showIdea.RespondButton.click();- await browser.wait(elementIsVisible(() => pages.showIdea.ResponseModal));-- // Action & Assert- await pages.showIdea.changeStatus('Planned', 'We will work on this soon...');- await browser.wait(elementIsVisible(() => pages.showIdea.Status));- await ensure(pages.showIdea.Status).textIs('PLANNED');- await ensure(pages.showIdea.ResponseText).textIs('We will work on this soon...');- });-- it('Admin can change status to another one', async () => {- // Action & Assert- await pages.showIdea.RespondButton.click();- await browser.wait(elementIsVisible(() => pages.showIdea.ResponseModal));- await pages.showIdea.changeStatus('Planned', 'We will work on this soon...');- await browser.wait(elementIsVisible(() => pages.showIdea.Status));- await ensure(pages.showIdea.Status).textIs('PLANNED');- await ensure(pages.showIdea.ResponseText).textIs('We will work on this soon...');- });-- it('Authenticated user can comment on an idea', async () => {- // Action & Assert- await pages.home.navigate();- await pages.home.IdeaList.navigateAndWait(0, pages.showIdea.loadCondition());- await ensure(pages.showIdea.SubmitCommentButton).isNotVisible();-- // Action & Assert- await pages.showIdea.CommentInput.type('This is my first comment');- await ensure(pages.showIdea.SubmitCommentButton).isVisible();-- // Action & Assert- await pages.showIdea.SubmitCommentButton.click();- await browser.wait(async () => await pages.showIdea.CommentList.count() === 1);- });-- it('Unauthenticated user cannot comment on an idea', async () => {- // Action & Assert- await pages.home.navigate();- await pages.home.signOut();- await pages.home.IdeaList.navigateAndWait(0, pages.showIdea.loadCondition());- assertEqual(await pages.showIdea.CommentList.count(), 1);-- // Action & Assert- await pages.showIdea.CommentInput.click();- await browser.wait(elementIsVisible(() => pages.home.SignInModal));- });-- it('Unauthenticated user cannot see actions', async () => {- // Action & Assert- await pages.home.navigate();- await pages.home.signOut();- await pages.home.IdeaList.navigateAndWait(0, pages.showIdea.loadCondition());- await ensure(pages.showIdea.RespondButton).isNotVisible();- });-- it('Can sign in with Google and support an idea', async () => {- // Action & Assert- await pages.home.navigate();- await pages.home.signInWithGoogle();- await pages.google.signInAsDarthVader();- await pages.home.UserMenu.click();- await ensure(pages.home.UserName).textIs('DARTH VADER');-- // Action & Assert- await pages.home.IdeaList.want(0);- await ensure(await pages.home.IdeaList.at(0)).textIs('2');- });-- it('User can sign in using e-mail on existing tenant', async () => {- const now = new Date().getTime();-- // Action- await pages.home.navigate();- await pages.home.signInWithEmail(`darthvader.fider+${now}@gmail.com`);-- const link = await mailgun.getLinkFromLastEmailTo(`darthvader.fider+${now}@gmail.com`);-- await pages.goTo(link);- await browser.wait(pages.home.loadCondition());-- await pages.home.completeSignIn(`Darth Vader ${now}`);-- // Assert- await pages.home.UserMenu.click();- await ensure(pages.home.UserName).textIs(`DARTH VADER ${now}`);- });-- it.skip('Admin can change Title, Invitation and Welcom Message', async () => {- return true;- });-});diff --git a/tests/testcases/admin.ts b/tests/testcases/admin.tsnew file mode 100644index 000000000..94e2279a1--- /dev/null+++ b/tests/testcases/admin.ts@@ -0,0 +1,112 @@+import { ensure, elementIsVisible, elementIsNotVisible, } from '../lib';+import { pages, browser } from '../context';++it('User is authenticated after sign up', async () => {+ // Action+ await pages.home.navigate();+ await pages.home.UserMenu.click();++ // Assert+ await ensure(pages.home.UserName).textIs('JON SNOW');+});++it('User doesn\'t lose what they typed', async () => {+ // Action+ await pages.home.navigate();+ await pages.home.IdeaTitle.type('My Great Idea');+ await pages.home.IdeaDescription.type('With an awesome description');++ await pages.home.IdeaTitle.clear();+ await pages.home.IdeaTitle.type('My Great Idea has a new title');++ // Assert+ await ensure(pages.home.IdeaTitle).textIs('My Great Idea has a new title');+ await ensure(pages.home.IdeaDescription).textIs('With an awesome description');++ // Action+ await pages.home.navigate();++ // Assert+ await ensure(pages.home.IdeaTitle).textIs('My Great Idea has a new title');+ await ensure(pages.home.IdeaDescription).textIs('With an awesome description');++ // Action+ await pages.home.IdeaDescription.clear();+ await pages.home.IdeaTitle.clear();+ await pages.home.navigate();++ // Assert+ await ensure(pages.home.IdeaTitle).textIs('');+ await browser.wait(elementIsNotVisible(() => pages.home.IdeaDescription));+});++it('Can submit ideas', async () => {+ // Action+ await pages.home.navigate();+ await pages.home.submitNewIdea('Add support to TypeScript', 'Because the language and community is awesome! :)');++ // Assert+ await ensure(pages.showIdea.Title).textIs('Add support to TypeScript');+ await ensure(pages.showIdea.Description).textIs('Because the language and community is awesome! :)');+ await ensure(pages.showIdea.SupportCounter).textIs('1');+});++it('Can change status', async () => {+ // Action & Assert+ await pages.home.navigate();+ await pages.home.IdeaList.navigateAndWait(0, pages.showIdea.loadCondition());+ await pages.showIdea.RespondButton.click();+ await browser.wait(elementIsVisible(() => pages.showIdea.ResponseModal));++ // Action & Assert+ await pages.showIdea.changeStatus('Planned', 'We will work on this soon...');+ await browser.wait(elementIsVisible(() => pages.showIdea.Status));+ await ensure(pages.showIdea.Status).textIs('PLANNED');+ await ensure(pages.showIdea.ResponseText).textIs('We will work on this soon...');+});++it('Can change status to another one', async () => {+ // Action & Assert+ await pages.showIdea.RespondButton.click();+ await browser.wait(elementIsVisible(() => pages.showIdea.ResponseModal));+ await pages.showIdea.changeStatus('Planned', 'We will work on this soon...');+ await browser.wait(elementIsVisible(() => pages.showIdea.Status));+ await ensure(pages.showIdea.Status).textIs('PLANNED');+ await ensure(pages.showIdea.ResponseText).textIs('We will work on this soon...');+});++it('Can comment on an idea', async () => {+ // Action & Assert+ await pages.home.navigate();+ await pages.home.IdeaList.navigateAndWait(0, pages.showIdea.loadCondition());+ await ensure(pages.showIdea.SubmitCommentButton).isNotVisible();++ // Action & Assert+ await pages.showIdea.CommentInput.type('This is my first comment');+ await ensure(pages.showIdea.SubmitCommentButton).isVisible();++ // Action & Assert+ await pages.showIdea.SubmitCommentButton.click();+ await browser.wait(async () => await pages.showIdea.CommentList.count() === 1);+});++it('Can change Title, Invitation and Welcome Message', async () => {+ await pages.adminSettings.navigate();++ await pages.adminSettings.TitleInput.clear();+ await pages.adminSettings.TitleInput.type('Selenium Feedback');++ await pages.adminSettings.WelcomeMessageInput.clear();+ await pages.adminSettings.WelcomeMessageInput.type('Welcome to our Selenium Feedback Forum');++ await pages.adminSettings.InvitationInput.clear();+ await pages.adminSettings.InvitationInput.type('Say something...');++ await pages.adminSettings.ConfirmButton.click();++ await browser.wait(pages.home.loadCondition());++ await ensure(pages.home.MenuTitle).textIs('Selenium Feedback');+ await ensure(pages.home.WelcomeMessage).textIs('Welcome to our Selenium Feedback Forum');+ await ensure(pages.home.IdeaTitle).attributeIs('placeholder', 'Say something...');+});diff --git a/tests/testcases/anonymous.ts b/tests/testcases/anonymous.tsnew file mode 100644index 000000000..027acfe48--- /dev/null+++ b/tests/testcases/anonymous.ts@@ -0,0 +1,22 @@+import { ensure, elementIsVisible } from '../lib';+import { pages, browser } from '../context';++it('Cannot submit ideas', async () => {+ // Action+ await pages.home.navigate();+ await pages.home.IdeaTitle.click();++ // Assert+ await browser.wait(elementIsVisible(() => pages.home.SignInModal));+});++it('Cannot see actions or comment on an idea', async () => {+ // Action & Assert+ await pages.home.navigate();+ await pages.home.IdeaList.navigateAndWait(0, pages.showIdea.loadCondition());+ await ensure(pages.showIdea.RespondButton).isNotVisible();++ // Action & Assert+ await pages.showIdea.CommentInput.click();+ await browser.wait(elementIsVisible(() => pages.home.SignInModal));+});diff --git a/tests/testcases/SignUpByEmail.ts b/tests/testcases/email-signup.tssimilarity index 76%rename from tests/testcases/SignUpByEmail.tsrename to tests/testcases/email-signup.tsindex eafc83db9..59008cecd 100644--- a/tests/testcases/SignUpByEmail.ts+++ b/tests/testcases/email-signup.ts@@ -1,10 +1,13 @@-import { ensure, elementIsVisible, mailgun, delay } from '../lib';-import { pages, tenant, browser } from '../context';-import { initialize } from './setup';+import { ensure, elementIsVisible, mailgun, Browser } from '../lib';+import { AllPages } from '../pages';describe('Sign up by e-mail', () => {+ let browser: Browser;+ let pages: AllPages;+before(async () => {- initialize();+ browser = new Browser('chrome');+ pages = new AllPages(browser);});after(async () => {diff --git a/tests/testcases/entry.ts b/tests/testcases/entry.tsnew file mode 100644index 000000000..76ee67aa8--- /dev/null+++ b/tests/testcases/entry.ts@@ -0,0 +1,48 @@+import { Browser } from '../lib';+import { setPages, setBrowser, setTenant } from '../context';+import { AllPages } from '../pages';++describe('Using Fider', () => {+ let browser: Browser;+ let pages: AllPages;++ before(async () => {+ const now = new Date().getTime();+ const tenantName = `Selenium ${now}`;+ const tenantSubdomain = `selenium${now}`;+ setTenant(tenantSubdomain);++ browser = new Browser('chrome');+ pages = new AllPages(browser);++ setBrowser(browser);+ setPages(pages);++ await pages.signup.navigate();+ await pages.signup.signInWithFacebook();+ await pages.facebook.signInAsJonSnow();++ await pages.signup.signUpAs(tenantName, tenantSubdomain);+ });++ after(async () => {+ await pages.dispose();+ });++ describe('As an Admin', () => {+ require('./admin');+ });++ describe('As an anonymous user', () => {+ before(async () => {+ await pages.home.navigate();+ await pages.home.signOut();+ });+ require('./anonymous');+ });++ describe('Alternative sign in', () => {+ require('./signin');+ });++});diff --git a/tests/testcases/setup.ts b/tests/testcases/setup.tsdeleted file mode 100644index f7512653d..000000000--- a/tests/testcases/setup.ts+++ /dev/null@@ -1,30 +0,0 @@-import { ensure, Browser } from '../lib';-import { AllPages } from '../pages';-import { setPages, setBrowser, setTenant } from '../context';--export function initialize() {- const browser = new Browser('chrome');- const pages = new AllPages(browser);-- setBrowser(browser);- setPages(pages);-}--export async function createTenant() {- const now = new Date().getTime();- const tenantName = `Selenium ${now}`;- const tenantSubdomain = `selenium${now}`;- setTenant(tenantSubdomain);-- const browser = new Browser('chrome');- const pages = new AllPages(browser);-- setBrowser(browser);- setPages(pages);-- await pages.signup.navigate();- await pages.signup.signInWithFacebook();- await pages.facebook.signInAsJonSnow();-- await pages.signup.signUpAs(tenantName, tenantSubdomain);-}diff --git a/tests/testcases/signin.ts b/tests/testcases/signin.tsnew file mode 100644index 000000000..ccecaac4e--- /dev/null+++ b/tests/testcases/signin.ts@@ -0,0 +1,34 @@+import { ensure, elementIsVisible, mailgun } from '../lib';+import { pages, browser } from '../context';++it('Can sign in with Google and support an idea', async () => {+ // Action & Assert+ await pages.home.navigate();+ await pages.home.signInWithGoogle();+ await pages.google.signInAsDarthVader();+ await pages.home.UserMenu.click();+ await ensure(pages.home.UserName).textIs('DARTH VADER');++ // Action & Assert+ await pages.home.IdeaList.want(0);+ await ensure(await pages.home.IdeaList.at(0)).textIs('2');+});++it('User can sign in using e-mail on existing tenant', async () => {+ const now = new Date().getTime();++ // Action+ await pages.home.navigate();+ await pages.home.signInWithEmail(`darthvader.fider+${now}@gmail.com`);++ const link = await mailgun.getLinkFromLastEmailTo(`darthvader.fider+${now}@gmail.com`);++ await pages.goTo(link);+ await browser.wait(pages.home.loadCondition());++ await pages.home.completeSignIn(`Darth Vader ${now}`);++ // Assert+ await pages.home.UserMenu.click();+ await ensure(pages.home.UserName).textIs(`DARTH VADER ${now}`);+});diff --git a/tsconfig.json b/tsconfig.jsonindex 81f11d1cf..17ca94594 100755--- a/tsconfig.json+++ b/tsconfig.json@@ -2,8 +2,7 @@"compilerOptions": {"module": "commonjs","target": "es5",- "noImplicitAny": true,- "strictNullChecks": true,+ "strict": true,"sourceMap": true,"outDir": "output/tsc","jsx": "react",