Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

fix(a11y): stop marking every modal as aria-disabled

Matt Roberts823fe9fc03c3
diff --git a/public/components/common/Modal.tsx b/public/components/common/Modal.tsx
index d34dd94f8..8736bbf37 100644
--- a/public/components/common/Modal.tsx
+++ b/public/components/common/Modal.tsx
@@ -69,9 +69,9 @@ const ModalWindow: React.FunctionComponent<ModalWindowProps> = ({ size = "small"
})
return ReactDOM.createPortal(
- <div aria-disabled={true} className="c-modal-dimmer" onClick={close}>
+ <div className="c-modal-dimmer" onClick={close}>
<div className="c-modal-scroller">
- <div className={className} data-testid="modal" onClick={swallow}>
+ <div className={className} role="dialog" aria-modal="true" data-testid="modal" onClick={swallow}>
{props.children}
</div>
</div>