Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

refactor: enable react strict mode (#813)

Guilherme Oenning9e9848794e43
diff --git a/public/components/common/DropDown.tsx b/public/components/common/DropDown.tsx
index a45a2eee0..feb523b90 100644
--- a/public/components/common/DropDown.tsx
+++ b/public/components/common/DropDown.tsx
@@ -1,5 +1,4 @@
import React from "react";
-import { findDOMNode } from "react-dom";
import { classSet } from "@fider/services";
import "./DropDown.scss";
@@ -33,6 +32,7 @@ export interface DropDownState {
}
export class DropDown extends React.Component<DropDownProps, DropDownState> {
+ private rootElementRef: React.RefObject<HTMLDivElement>;
private mounted = false;
public static defaultProps: Partial<DropDownProps> = {
@@ -43,6 +43,7 @@ export class DropDown extends React.Component<DropDownProps, DropDownState> {
constructor(props: DropDownProps) {
super(props);
+ this.rootElementRef = React.createRef<HTMLDivElement>();
this.state = {
selected: this.findItem(props.defaultValue, props.items),
isOpen: false
@@ -147,7 +148,7 @@ export class DropDown extends React.Component<DropDownProps, DropDownState> {
public handleDocumentClick = (event: any) => {
if (this.mounted) {
- const node = findDOMNode(this);
+ const node = this.rootElementRef.current;
if (node && !node.contains(event.target)) {
if (this.state.isOpen) {
this.setState(
@@ -181,7 +182,7 @@ export class DropDown extends React.Component<DropDownProps, DropDownState> {
});
return (
- <div className={dropdownClass}>
+ <div ref={this.rootElementRef} className={dropdownClass}>
<div onMouseDown={this.handleMouseDown} onTouchEnd={this.handleMouseDown}>
{this.props.renderControl ? (
<div className="c-dropdown-control">{this.props.renderControl(this.state.selected)}</div>
diff --git a/public/components/common/SignInControl.tsx b/public/components/common/SignInControl.tsx
index 88019a510..6e1fdf09c 100644
--- a/public/components/common/SignInControl.tsx
+++ b/public/components/common/SignInControl.tsx
@@ -17,11 +17,11 @@ export const SignInControl: React.FunctionComponent<SignInControlProps> = props
const signIn = async () => {
const result = await actions.signIn(email);
if (result.ok) {
+ setEmail("");
+ setError(undefined);
if (props.onEmailSent) {
props.onEmailSent(email);
}
- setEmail("");
- setError(undefined);
} else if (result.error) {
setError(result.error);
}
diff --git a/public/index.tsx b/public/index.tsx
index 8b741fb2b..0d8a96621 100644
--- a/public/index.tsx
+++ b/public/index.tsx
@@ -54,15 +54,17 @@ window.addEventListener("error", (evt: ErrorEvent) => {
"is-staff": fider.session.isAuthenticated && fider.session.user.isCollaborator
});
ReactDOM.render(
- <ErrorBoundary onError={logProductionError}>
- <FiderContext.Provider value={fider}>
- <IconContext.Provider value={{ className: "icon" }}>
- {config.showHeader && <Header />}
- <Suspense fallback={<Loading />}>{React.createElement(config.component, fider.session.props)}</Suspense>
- {config.showHeader && <Footer />}
- </IconContext.Provider>
- </FiderContext.Provider>
- </ErrorBoundary>,
+ <React.StrictMode>
+ <ErrorBoundary onError={logProductionError}>
+ <FiderContext.Provider value={fider}>
+ <IconContext.Provider value={{ className: "icon" }}>
+ {config.showHeader && <Header />}
+ <Suspense fallback={<Loading />}>{React.createElement(config.component, fider.session.props)}</Suspense>
+ {config.showHeader && <Footer />}
+ </IconContext.Provider>
+ </FiderContext.Provider>
+ </ErrorBoundary>
+ </React.StrictMode>,
document.getElementById("root")
);
})();
diff --git a/public/pages/ShowPost/components/PostSearch.tsx b/public/pages/ShowPost/components/PostSearch.tsx
index c92dbce10..e59cfaf1d 100644
--- a/public/pages/ShowPost/components/PostSearch.tsx
+++ b/public/pages/ShowPost/components/PostSearch.tsx
@@ -21,6 +21,9 @@ export class PostSearch extends React.Component<PostSearchProps, PostSearchState
this.state = {
posts: []
};
+ }
+
+ public componentDidMount() {
this.search("");
}